fix: [Security:Explore:Users page]Add new timeline or template button dialog cannot be closed #207232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dialog cannot be closed Closes: elastic#205377
alexwizp
added
v9.0.0
backport:prev-minor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
PhilippeOberti
approved these changes
Jan 21, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 22, 2025
… dialog cannot be closed (elastic#207232) Closes: elastic#205377 **Description** Users don't get stuck on elements, dialogs can be closed by pressing Esc. **Preconditions** Security -> Explore -> Users page. **Steps to reproduce** 1.Navigate to Add new timeline or template button. 2.Press Enter. 3.Press Esc. 4.Press Tab few times. 5.Observe page. **Changes made:** 1. Fixed typo, method should be called (cherry picked from commit e2c138b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 22, 2025
…button dialog cannot be closed (#207232) (#207702) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Security:Explore:Users page]Add new timeline or template button dialog cannot be closed (#207232)](#207232) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-22T08:22:55Z","message":"fix: [Security:Explore:Users page]Add new timeline or template button dialog cannot be closed (#207232)\n\nCloses: #205377\r\n\r\n**Description**\r\nUsers don't get stuck on elements, dialogs can be closed by pressing\r\nEsc.\r\n\r\n**Preconditions**\r\nSecurity -> Explore -> Users page.\r\n\r\n**Steps to reproduce**\r\n\r\n1.Navigate to Add new timeline or template button.\r\n2.Press Enter.\r\n3.Press Esc.\r\n4.Press Tab few times.\r\n5.Observe page.\r\n\r\n\r\n**Changes made:**\r\n1. Fixed typo, method should be called","sha":"e2c138bca119015715e26ac519f2eb75b98e1541","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","backport:prev-minor"],"title":"fix: [Security:Explore:Users page]Add new timeline or template button dialog cannot be closed","number":207232,"url":"https://github.com/elastic/kibana/pull/207232","mergeCommit":{"message":"fix: [Security:Explore:Users page]Add new timeline or template button dialog cannot be closed (#207232)\n\nCloses: #205377\r\n\r\n**Description**\r\nUsers don't get stuck on elements, dialogs can be closed by pressing\r\nEsc.\r\n\r\n**Preconditions**\r\nSecurity -> Explore -> Users page.\r\n\r\n**Steps to reproduce**\r\n\r\n1.Navigate to Add new timeline or template button.\r\n2.Press Enter.\r\n3.Press Esc.\r\n4.Press Tab few times.\r\n5.Observe page.\r\n\r\n\r\n**Changes made:**\r\n1. Fixed typo, method should be called","sha":"e2c138bca119015715e26ac519f2eb75b98e1541"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207232","number":207232,"mergeCommit":{"message":"fix: [Security:Explore:Users page]Add new timeline or template button dialog cannot be closed (#207232)\n\nCloses: #205377\r\n\r\n**Description**\r\nUsers don't get stuck on elements, dialogs can be closed by pressing\r\nEsc.\r\n\r\n**Preconditions**\r\nSecurity -> Explore -> Users page.\r\n\r\n**Steps to reproduce**\r\n\r\n1.Navigate to Add new timeline or template button.\r\n2.Press Enter.\r\n3.Press Esc.\r\n4.Press Tab few times.\r\n5.Observe page.\r\n\r\n\r\n**Changes made:**\r\n1. Fixed typo, method should be called","sha":"e2c138bca119015715e26ac519f2eb75b98e1541"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #205377
Description
Users don't get stuck on elements, dialogs can be closed by pressing Esc.
Preconditions
Security -> Explore -> Users page.
Steps to reproduce
1.Navigate to Add new timeline or template button.
2.Press Enter.
3.Press Esc.
4.Press Tab few times.
5.Observe page.
Changes made: