[Response Ops][Task Manager] Validate Task Instance During "mGet" Task Claiming #207158
+227
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaweiWu
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ymao1
reviewed
Jan 21, 2025
| @@ -169,6 +171,17 @@ async function claimAvailableTasks(opts: TaskClaimerOpts): Promise<ClaimOwnershi | |||
| const now = new Date(); | |||
| const taskUpdates: PartialConcreteTaskInstance[] = []; | |||
| for (const task of tasksToRun) { | |||
| try { | |||
| concreteTaskInstanceSchema.validate(task); | |||
There was a problem hiding this comment.
This validation currently catches the PT1M issue because we changed the schema for that field from schema.duration to schema.string, however prior to that fix, using this validation would not have caught the PT1M issue. I think because the goal of the issue is to catch the unknown unknown errors, we should be aiming more broadly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #204466
This PR adds schema validation to the task instance during the mGet task claiming strategy logic. This should ensure malformed tasks do no short circuit other tasks from being claimed. Not sure if this is overkill but it seems like a good approach to have runtime validation instead of just a try and catch over the entire task claiming logic.
Checklist