Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Fleet validation using the RequiredVars and CSPM showing validation errors #207130

Merged
merged 23 commits into from
Jan 28, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed CSPM instration
seanrathier committed Jan 28, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 03f7819c4328ef15a1b87ba9181ef2e087a63f3c
Original file line number Diff line number Diff line change
@@ -52,6 +52,7 @@ import {
type NewPackagePolicyPostureInput,
POSTURE_NAMESPACE,
POLICY_TEMPLATE_FORM_DTS,
hasErrors,
} from './utils';
import {
PolicyTemplateInfo,
@@ -763,9 +764,7 @@ export const CspPolicyTemplateForm = memo<PackagePolicyReplaceDefineStepExtensio
const validationResultsNonNullFields = Object.keys(validationResults?.vars || {}).filter(
(key) => (validationResults?.vars || {})[key] !== null
);

const inputName = `${input.policy_template}-${input.type}`;
const hasInvalidRequiredVars = !!validationResults?.inputs?.[inputName]?.required_vars;
const hasInvalidRequiredVars = hasErrors(validationResults);

const [isLoading, setIsLoading] = useState(validationResultsNonNullFields.length > 0);
const [canFetchIntegration, setCanFetchIntegration] = useState(true);
Original file line number Diff line number Diff line change
@@ -43,6 +43,8 @@ import {
} from './aws_credentials_form/get_aws_credentials_form_options';
import { GCP_CREDENTIALS_TYPE, GCP_SETUP_ACCESS } from './gcp_credentials_form/gcp_credential_form';
import { AZURE_CREDENTIALS_TYPE } from './azure_credentials_form/azure_credentials_form';
import { PackagePolicyValidationResults } from '@kbn/fleet-plugin/common/services';
import { getFlattenedObject } from '@kbn/std';

// Posture policies only support the default namespace
export const POSTURE_NAMESPACE = 'default';
@@ -401,3 +403,11 @@ export const fieldIsInvalid = (value: string | undefined, hasInvalidRequiredVars
export const POLICY_TEMPLATE_FORM_DTS = {
LOADER: 'policy-template-form-loader',
};

export const hasErrors = (validationResults: PackagePolicyValidationResults | undefined) => {
if (!validationResults) return 0;

const flattenedValidation = getFlattenedObject(validationResults);
const errors = Object.values(flattenedValidation).filter((value) => Boolean(value)) || [];
return errors.length;
};