[Security Solution] Show deprecated bulk endpoints in Upgrade Assistant #207091

nikitaindik · 2025-01-17T15:11:09Z

Partially addresses: #193184

Summary

We are going to remove our deprecated bulk action endpoints in v9.0.0. They are already unavailable in main.

This PR makes deprecated bulk endpoints visible in Upgrade Assistant. Also, it adds an upgrade guide to the documentation to help users transition to supported endpoints.

⚠️ This PR temporarily adds the deprecated endpoints back to register_routes.ts. This is needed to make merging changes easier. I'll open up a follow up PR for main that will delete these endpoints from 9.0. Will do it once this PR is merged.

Screenshots

Deprecated endpoints visible in Upgrade Assistant table

Clicking on a table item opens a flyout with more info

Clicking on "Learn more" in the flyout takes you to the upgrade guide

Testing

Once you send a request to one of the deprecated endpoints it should show up in Upgrade Assistant at <basePath>/app/management/stack/upgrade_assistant/kibana_deprecations.
Please refer to this ticket for the list of deprecated endpoints.

Work started on: 16-Jan-2025

github-actions · 2025-01-17T15:11:26Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

nikitaindik · 2025-01-20T14:50:00Z

run docs-build

nikitaindik · 2025-01-20T16:50:02Z

run docs-build

nikitaindik · 2025-01-21T10:24:27Z

run docs-build

elasticmachine · 2025-01-21T10:45:19Z

Pinging @elastic/security-detections-response (Team:Detections and Resp)

elasticmachine · 2025-01-21T10:45:21Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2025-01-21T10:45:22Z

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

banderror · 2025-01-21T11:23:48Z

Hey @nikitaindik, could you please post a screenshot of the flyout for each deprecation issue from the first screenshot?

nikitaindik · 2025-01-22T11:16:07Z

It works properly for me on Chrome even when opening in the same browser tab. Can you try clearing your cache or using incognito mode to see if that works?

@natasha-moore-elastic It seems to be intermittent when opening a new tab in Chrome for me - sometimes works, sometimes doesn't. If you open in a new window or incognito it works every time.

To make things a bit simpler, we can use the attribute for the API reference instead of hard-coding the URL

Done! Thanks, indeed hardcoding it wasn't a good idea!

nikitaindik · 2025-01-22T11:16:48Z

run docs-build

natasha-moore-elastic · 2025-01-22T11:22:13Z

It works properly for me on Chrome even when opening in the same browser tab. Can you try clearing your cache or using incognito mode to see if that works?

@natasha-moore-elastic It seems to be intermittent when opening a new tab in Chrome for me - sometimes works, sometimes doesn't. If you open in a new window or incognito it works every time.

To make things a bit simpler, we can use the attribute for the API reference instead of hard-coding the URL

Done! Thanks, indeed hardcoding it wasn't a good idea!

Let's see what it's like now when the updated links build. 🤞 I see here that the Kibana API docs were updated last night, so maybe that's what's causing the glitch for you and Nastasha.

nikitaindik · 2025-01-22T12:47:07Z

run docs-build rebuild

…t endpoint

…ore team

elasticmachine · 2025-01-22T15:47:34Z

💚 Build Succeeded

Buildkite Build
Commit: 8b8b6ed
Cloud Deployment
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-207091-8b8b6eda9ed7
Security Deployment

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiAssistantManagementSelection`	93.5KB	93.6KB	+78.0B
`lists`	142.9KB	143.0KB	+78.0B
`securitySolution`	21.3MB	21.3MB	-78.0B
total			+78.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	483.7KB	483.8KB	+78.0B
`securitySolution`	88.1KB	88.1KB	+55.0B
total			+133.0B

History

💛 Build #269195 was flaky 00e8e00
💛 Build #268923 was flaky 38b671b
💚 Build #268739 succeeded 1e4d48a
💔 Build #268583 failed 55399e8

cc @nikitaindik

kibanamachine · 2025-01-22T16:36:42Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12912813832

kibanamachine · 2025-01-22T16:42:09Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 207091

Questions ?

Please refer to the Backport tool documentation

nikitaindik · 2025-01-22T16:59:07Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…nt (elastic#207091) **Partially addresses: elastic#193184 ## Summary We are going to remove our deprecated [bulk action endpoints](elastic#193184) in v9.0.0. They are already unavailable in `main`. This PR makes deprecated bulk endpoints visible in Upgrade Assistant. Also, it adds an upgrade guide to the documentation to help users transition to supported endpoints. ⚠️ This PR temporarily adds the deprecated endpoints back to `register_routes.ts`. This is needed to make merging changes easier. I'll open up a follow up PR for `main` that will delete these endpoints from `9.0`. Will do it once this PR is merged. ## Screenshots **Deprecated endpoints visible in Upgrade Assistant table** <img width="1276" alt="Schermafbeelding 2025-01-21 om 11 27 53" src="https://github.com/user-attachments/assets/909c7a20-31d9-46bb-89ec-b409550074e4" /> **Clicking on a table item opens a flyout with more info** <table> <tr> <td> <img width="1270" alt="patch_update" src="https://github.com/user-attachments/assets/8e99459d-1ea1-40c4-936c-23074c02cd6f" /> </td> <td> <img width="1270" alt="post_create" src="https://github.com/user-attachments/assets/6e734e97-4cf4-4d96-9f8d-51efeb3977ad" /> </td> </tr> <tr> <td> <img width="1270" alt="put_update" src="https://github.com/user-attachments/assets/d5b08e16-bf49-475d-81a9-fe5654483e1d" /> </td> <td> <img width="1271" alt="post_delete" src="https://github.com/user-attachments/assets/ccb74552-50a4-4bdb-b04e-06857caa8f38" /> </td> </tr> </table> **Clicking on "Learn more" in the flyout takes you to the [upgrade guide](https://kibana_bk_207091.docs-preview.app.elstc.co/guide/en/kibana/master/breaking-changes-summary.html#breaking-207091)** <img width="731" alt="upgrade_notes" src="https://github.com/user-attachments/assets/b8b471ea-98c7-4b07-91db-b1630c382554" /> ## Testing Once you send a request to one of the deprecated endpoints it should show up in Upgrade Assistant at `<basePath>/app/management/stack/upgrade_assistant/kibana_deprecations`. Please refer to [this ticket](elastic#193184) for the list of deprecated endpoints. Work started on: 16-Jan-2025

nikitaindik self-assigned this Jan 17, 2025

nikitaindik mentioned this pull request Jan 17, 2025

[Security Solution] Disable deprecated rules bulk CRUD API endpoints #193184

Open

nikitaindik force-pushed the upgrade-assistant-deprecated-bulk-endpoints branch from f7bed16 to 0274146 Compare January 20, 2025 14:47

nikitaindik force-pushed the upgrade-assistant-deprecated-bulk-endpoints branch from 55399e8 to c536de8 Compare January 21, 2025 09:55

nikitaindik added ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-security Create a Security Serverless Project labels Jan 21, 2025

nikitaindik marked this pull request as ready for review January 21, 2025 10:45

nikitaindik requested review from a team as code owners January 21, 2025 10:45

nikitaindik requested a review from dplumlee January 21, 2025 10:45

nikitaindik requested a review from jkelas January 21, 2025 11:21

nikitaindik added 13 commits January 22, 2025 16:01

Initial commit to create a PR ID

c546c11

Add a docLink

7c05561

Add new endpoints to "Breaking changes" section on upgrade-notes.ascii

8c41d5e

Start tracking stats for _bulk_create, add a constant for the impor…

c181271

…t endpoint

Start tracking stats for PUT _bulk_update

130f7de

Start tracking stats for _bulk_delete

92290c6

Fix typos in upgrade-notes.ascii

69f22dc

Update args in tests

d14b4bf

Update a comment

aea216e

Address code review comments from the docs folks

65cd438

Update wording in docs

e25e4e1

Use a var for doc URLs instead of hardcoding

98736c9

Change deprecation "severity" to critical after consulting with the C…

8b8b6ed

…ore team

nikitaindik force-pushed the upgrade-assistant-deprecated-bulk-endpoints branch from 00e8e00 to 8b8b6ed Compare January 22, 2025 15:01

nikitaindik requested review from natasha-moore-elastic and nastasha-solomon January 22, 2025 15:02

natasha-moore-elastic approved these changes Jan 22, 2025

View reviewed changes

nikitaindik enabled auto-merge (squash) January 22, 2025 15:11

nikitaindik merged commit 3314537 into elastic:main Jan 22, 2025
8 checks passed

nikitaindik mentioned this pull request Jan 22, 2025

[8.x] [Security Solution] Show deprecated bulk endpoints in Upgrade Assistant (#207091) #207882

Open

nikitaindik mentioned this pull request Jan 22, 2025

[Security Solution] Remove deprecated bulk endpoints from v9.0.0 #207906

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Show deprecated bulk endpoints in Upgrade Assistant #207091

[Security Solution] Show deprecated bulk endpoints in Upgrade Assistant #207091

nikitaindik commented Jan 17, 2025 •

edited by kibanamachine

Loading

github-actions bot commented Jan 17, 2025

nikitaindik commented Jan 20, 2025

nikitaindik commented Jan 20, 2025

nikitaindik commented Jan 21, 2025

elasticmachine commented Jan 21, 2025

elasticmachine commented Jan 21, 2025

elasticmachine commented Jan 21, 2025

banderror commented Jan 21, 2025

nikitaindik commented Jan 22, 2025

nikitaindik commented Jan 22, 2025

natasha-moore-elastic commented Jan 22, 2025 •

edited

Loading

nikitaindik commented Jan 22, 2025

elasticmachine commented Jan 22, 2025 •

edited

Loading

kibanamachine commented Jan 22, 2025

kibanamachine commented Jan 22, 2025

nikitaindik commented Jan 22, 2025

[Security Solution] Show deprecated bulk endpoints in Upgrade Assistant #207091

[Security Solution] Show deprecated bulk endpoints in Upgrade Assistant #207091

Conversation

nikitaindik commented Jan 17, 2025 • edited by kibanamachine Loading

Summary

Screenshots

Testing

github-actions bot commented Jan 17, 2025

nikitaindik commented Jan 20, 2025

nikitaindik commented Jan 20, 2025

nikitaindik commented Jan 21, 2025

elasticmachine commented Jan 21, 2025

elasticmachine commented Jan 21, 2025

elasticmachine commented Jan 21, 2025

banderror commented Jan 21, 2025

nikitaindik commented Jan 22, 2025

nikitaindik commented Jan 22, 2025

natasha-moore-elastic commented Jan 22, 2025 • edited Loading

nikitaindik commented Jan 22, 2025

elasticmachine commented Jan 22, 2025 • edited Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

kibanamachine commented Jan 22, 2025

kibanamachine commented Jan 22, 2025

💔 All backports failed

Manual backport

Questions ?

nikitaindik commented Jan 22, 2025

💚 All backports created successfully

Questions ?

nikitaindik commented Jan 17, 2025 •

edited by kibanamachine

Loading

natasha-moore-elastic commented Jan 22, 2025 •

edited

Loading

elasticmachine commented Jan 22, 2025 •

edited

Loading