Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects the default max spaces in non-serverless docs #203857

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

jeramysoucy
Copy link
Contributor

@jeramysoucy jeramysoucy commented Dec 11, 2024

Summary

The max spaces is described as 100, but should be 1000 by default only in our non-serverless offerings. Only serverless is currently limited to 100.

See https://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@jeramysoucy jeramysoucy requested review from a team December 11, 2024 17:40
@jeramysoucy jeramysoucy marked this pull request as ready for review December 11, 2024 17:41
@jeramysoucy jeramysoucy added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! backport:skip This commit does not require backporting docs labels Dec 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@jeramysoucy jeramysoucy added the release_note:skip Skip the PR/issue when compiling release notes label Dec 11, 2024
@jeramysoucy jeramysoucy self-assigned this Dec 11, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cc @jeramysoucy

@kc13greiner kc13greiner self-requested a review December 11, 2024 17:55
@jeramysoucy jeramysoucy enabled auto-merge (squash) December 16, 2024 14:14
@jeramysoucy jeramysoucy merged commit 4ea032e into elastic:main Dec 16, 2024
8 checks passed
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
## Summary

The max spaces is described as 100, but should be 1000 by default only
in our non-serverless offerings. Only serverless is currently limited to
100.

See
https://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing

---------

Co-authored-by: wajihaparvez <[email protected]>
@lukeelmers lukeelmers added backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development v8.16.0 v8.17.0 v8.18.0 and removed backport:skip This commit does not require backporting labels Jan 9, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12681510948

@lukeelmers
Copy link
Member

Adding backport labels -- We should make sure docs fixes like this are included in previous versions of the docs as well -- otherwise nobody will see the correction unless they are looking at master / 9.0

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 9, 2025
## Summary

The max spaces is described as 100, but should be 1000 by default only
in our non-serverless offerings. Only serverless is currently limited to
100.

See
https://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing

---------

Co-authored-by: wajihaparvez <[email protected]>
(cherry picked from commit 4ea032e)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 9, 2025
## Summary

The max spaces is described as 100, but should be 1000 by default only
in our non-serverless offerings. Only serverless is currently limited to
100.

See
https://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing

---------

Co-authored-by: wajihaparvez <[email protected]>
(cherry picked from commit 4ea032e)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 9, 2025
## Summary

The max spaces is described as 100, but should be 1000 by default only
in our non-serverless offerings. Only serverless is currently limited to
100.

See
https://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing

---------

Co-authored-by: wajihaparvez <[email protected]>
(cherry picked from commit 4ea032e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.17
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 9, 2025
… (#205981)

# Backport

This will backport the following commits from `main` to `8.17`:
- [Corrects the default max spaces in non-serverless docs
(#203857)](#203857)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-16T14:40:13Z","message":"Corrects
the default max spaces in non-serverless docs (#203857)\n\n##
Summary\r\n\r\nThe max spaces is described as 100, but should be 1000 by
default only\r\nin our non-serverless offerings. Only serverless is
currently limited
to\r\n100.\r\n\r\nSee\r\nhttps://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing\r\n\r\n---------\r\n\r\nCo-authored-by:
wajihaparvez
<[email protected]>","sha":"4ea032eb48c8d458d802e5cd606217c1bc89f235","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","docs","backport:prev-major","v8.16.0","v8.17.0","v8.18.0"],"title":"Corrects
the default max spaces in non-serverless
docs","number":203857,"url":"https://github.com/elastic/kibana/pull/203857","mergeCommit":{"message":"Corrects
the default max spaces in non-serverless docs (#203857)\n\n##
Summary\r\n\r\nThe max spaces is described as 100, but should be 1000 by
default only\r\nin our non-serverless offerings. Only serverless is
currently limited
to\r\n100.\r\n\r\nSee\r\nhttps://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing\r\n\r\n---------\r\n\r\nCo-authored-by:
wajihaparvez
<[email protected]>","sha":"4ea032eb48c8d458d802e5cd606217c1bc89f235"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203857","number":203857,"mergeCommit":{"message":"Corrects
the default max spaces in non-serverless docs (#203857)\n\n##
Summary\r\n\r\nThe max spaces is described as 100, but should be 1000 by
default only\r\nin our non-serverless offerings. Only serverless is
currently limited
to\r\n100.\r\n\r\nSee\r\nhttps://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing\r\n\r\n---------\r\n\r\nCo-authored-by:
wajihaparvez
<[email protected]>","sha":"4ea032eb48c8d458d802e5cd606217c1bc89f235"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <[email protected]>
kibanamachine added a commit that referenced this pull request Jan 9, 2025
… (#205980)

# Backport

This will backport the following commits from `main` to `8.16`:
- [Corrects the default max spaces in non-serverless docs
(#203857)](#203857)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-16T14:40:13Z","message":"Corrects
the default max spaces in non-serverless docs (#203857)\n\n##
Summary\r\n\r\nThe max spaces is described as 100, but should be 1000 by
default only\r\nin our non-serverless offerings. Only serverless is
currently limited
to\r\n100.\r\n\r\nSee\r\nhttps://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing\r\n\r\n---------\r\n\r\nCo-authored-by:
wajihaparvez
<[email protected]>","sha":"4ea032eb48c8d458d802e5cd606217c1bc89f235","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","docs","backport:prev-major","v8.16.0","v8.17.0","v8.18.0"],"title":"Corrects
the default max spaces in non-serverless
docs","number":203857,"url":"https://github.com/elastic/kibana/pull/203857","mergeCommit":{"message":"Corrects
the default max spaces in non-serverless docs (#203857)\n\n##
Summary\r\n\r\nThe max spaces is described as 100, but should be 1000 by
default only\r\nin our non-serverless offerings. Only serverless is
currently limited
to\r\n100.\r\n\r\nSee\r\nhttps://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing\r\n\r\n---------\r\n\r\nCo-authored-by:
wajihaparvez
<[email protected]>","sha":"4ea032eb48c8d458d802e5cd606217c1bc89f235"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203857","number":203857,"mergeCommit":{"message":"Corrects
the default max spaces in non-serverless docs (#203857)\n\n##
Summary\r\n\r\nThe max spaces is described as 100, but should be 1000 by
default only\r\nin our non-serverless offerings. Only serverless is
currently limited
to\r\n100.\r\n\r\nSee\r\nhttps://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing\r\n\r\n---------\r\n\r\nCo-authored-by:
wajihaparvez
<[email protected]>","sha":"4ea032eb48c8d458d802e5cd606217c1bc89f235"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <[email protected]>
kibanamachine added a commit that referenced this pull request Jan 9, 2025
#205982)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Corrects the default max spaces in non-serverless docs
(#203857)](#203857)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-16T14:40:13Z","message":"Corrects
the default max spaces in non-serverless docs (#203857)\n\n##
Summary\r\n\r\nThe max spaces is described as 100, but should be 1000 by
default only\r\nin our non-serverless offerings. Only serverless is
currently limited
to\r\n100.\r\n\r\nSee\r\nhttps://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing\r\n\r\n---------\r\n\r\nCo-authored-by:
wajihaparvez
<[email protected]>","sha":"4ea032eb48c8d458d802e5cd606217c1bc89f235","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","docs","backport:prev-major","v8.16.0","v8.17.0","v8.18.0"],"title":"Corrects
the default max spaces in non-serverless
docs","number":203857,"url":"https://github.com/elastic/kibana/pull/203857","mergeCommit":{"message":"Corrects
the default max spaces in non-serverless docs (#203857)\n\n##
Summary\r\n\r\nThe max spaces is described as 100, but should be 1000 by
default only\r\nin our non-serverless offerings. Only serverless is
currently limited
to\r\n100.\r\n\r\nSee\r\nhttps://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing\r\n\r\n---------\r\n\r\nCo-authored-by:
wajihaparvez
<[email protected]>","sha":"4ea032eb48c8d458d802e5cd606217c1bc89f235"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203857","number":203857,"mergeCommit":{"message":"Corrects
the default max spaces in non-serverless docs (#203857)\n\n##
Summary\r\n\r\nThe max spaces is described as 100, but should be 1000 by
default only\r\nin our non-serverless offerings. Only serverless is
currently limited
to\r\n100.\r\n\r\nSee\r\nhttps://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing\r\n\r\n---------\r\n\r\nCo-authored-by:
wajihaparvez
<[email protected]>","sha":"4ea032eb48c8d458d802e5cd606217c1bc89f235"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
## Summary

The max spaces is described as 100, but should be 1000 by default only
in our non-serverless offerings. Only serverless is currently limited to
100.

See
https://www.elastic.co/guide/en/kibana/current/xpack-spaces.html#spaces-managing

---------

Co-authored-by: wajihaparvez <[email protected]>
@jeramysoucy jeramysoucy deleted the fix-spaces-doc branch February 11, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development docs release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.16.0 v8.16.3 v8.17.0 v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants