Fixed issue with Entity Risk Scoring Management page due to recent EUI #195666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredburgettelastic
added
backport:all-open
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2024
elastic#195666) ## Summary After the most recent EUI upgrade [here](elastic#194619), the Security Entity Risk Scoring Management page had significant spacing issues with regards to the page header. This PR alleviates those issues, and also simplifies the DOM structure for that component a bit. ## Before  ## After <img width="1727" alt="Screenshot 2024-10-09 at 1 20 14 PM" src="https://github.com/user-attachments/assets/4117d280-231d-48aa-b36b-82e99a8a294c"> (cherry picked from commit 52e7dec)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2024
…ent EUI (#195666) (#195987) # Backport This will backport the following commits from `main` to `8.x`: - [Fixed issue with Entity Risk Scoring Management page due to recent EUI (#195666)](#195666) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jared Burgett","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-11T19:22:03Z","message":"Fixed issue with Entity Risk Scoring Management page due to recent EUI (#195666)\n\n## Summary\r\n\r\nAfter the most recent EUI upgrade\r\n[here](#194619), the Security\r\nEntity Risk Scoring Management page had significant spacing issues with\r\nregards to the page header. This PR alleviates those issues, and also\r\nsimplifies the DOM structure for that component a bit.\r\n\r\n## Before\r\n\r\n\r\n\r\n\r\n\r\n## After \r\n\r\n<img width=\"1727\" alt=\"Screenshot 2024-10-09 at 1 20 14 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/4117d280-231d-48aa-b36b-82e99a8a294c\">","sha":"52e7dece2d26a249f90e9d0e332d0cd35e2c5eb2","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"Fixed issue with Entity Risk Scoring Management page due to recent EUI","number":195666,"url":"https://github.com/elastic/kibana/pull/195666","mergeCommit":{"message":"Fixed issue with Entity Risk Scoring Management page due to recent EUI (#195666)\n\n## Summary\r\n\r\nAfter the most recent EUI upgrade\r\n[here](#194619), the Security\r\nEntity Risk Scoring Management page had significant spacing issues with\r\nregards to the page header. This PR alleviates those issues, and also\r\nsimplifies the DOM structure for that component a bit.\r\n\r\n## Before\r\n\r\n\r\n\r\n\r\n\r\n## After \r\n\r\n<img width=\"1727\" alt=\"Screenshot 2024-10-09 at 1 20 14 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/4117d280-231d-48aa-b36b-82e99a8a294c\">","sha":"52e7dece2d26a249f90e9d0e332d0cd35e2c5eb2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195666","number":195666,"mergeCommit":{"message":"Fixed issue with Entity Risk Scoring Management page due to recent EUI (#195666)\n\n## Summary\r\n\r\nAfter the most recent EUI upgrade\r\n[here](#194619), the Security\r\nEntity Risk Scoring Management page had significant spacing issues with\r\nregards to the page header. This PR alleviates those issues, and also\r\nsimplifies the DOM structure for that component a bit.\r\n\r\n## Before\r\n\r\n\r\n\r\n\r\n\r\n## After \r\n\r\n<img width=\"1727\" alt=\"Screenshot 2024-10-09 at 1 20 14 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/4117d280-231d-48aa-b36b-82e99a8a294c\">","sha":"52e7dece2d26a249f90e9d0e332d0cd35e2c5eb2"}}]}] BACKPORT--> Co-authored-by: Jared Burgett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After the most recent EUI upgrade here, the Security Entity Risk Scoring Management page had significant spacing issues with regards to the page header. This PR alleviates those issues, and also simplifies the DOM structure for that component a bit.
Before
After