[SecuritySolutions] Create Asset Criticality CSV upload page #179891

machadoum · 2024-04-03T07:46:50Z

Summary

Create a new Asset Criticality page for updating asset criticality by file upload.
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5665
Server side PR: #179930

asset.criticality.upload.recording.mov

The new page has three steps. You can access the page by going to Security -> Manage -> Asset Criticality.

File picker Step:

File validation step

Result step

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
a-docker)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

How to test it?

Open the page
Upload a valid CSV file
Check if everything is ok on the validation step
Click Assign
Check if the success message is displayed
Open the alert flyout for an updated asset and check if it has the new value

What is not included?

Serverless
Disable the feature when asset criticality advanced setting is disabled

Code owners files:

elastic/docs

packages/kbn-doc-links/src/get_doc_links.ts
packages/kbn-doc-links/src/types.ts

elastic/security-defend-workflows

x-pack/plugins/security_solution/public/management/links.ts

elastic/security-detection-engine

x-pack/test/security_solution_cypress/cypress/urls/navigation.ts

elastic/security-detections-response

x-pack/test/security_solution_cypress/cypress/fixtures/asset_criticality.csv

elastic/security-engineering-productivity

x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/asset_criticality_upload_page.cy.ts
x-pack/test/security_solution_cypress/cypress/fixtures/asset_criticality.csv
x-pack/test/security_solution_cypress/cypress/screens/asset_criticality.ts
x-pack/test/security_solution_cypress/cypress/tasks/asset_criticality.ts
x-pack/test/security_solution_cypress/cypress/urls/navigation.ts

elastic/security-threat-hunting

x-pack/test/security_solution_cypress/cypress/fixtures/asset_criticality.csv

elastic/security-threat-hunting-investigations

x-pack/plugins/security_solution/public/resolver/view/panels/node_list.tsx
x-pack/test/security_solution_cypress/cypress/urls/navigation.ts

machadoum · 2024-04-08T14:23:39Z

/ci

machadoum · 2024-04-09T08:20:21Z

/ci

…ent-side

machadoum · 2024-04-11T13:24:38Z

/ci

elasticmachine · 2024-04-11T13:37:55Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2024-04-11T13:37:56Z

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

tomsonpl

Defend workflows review, lgtm 👍 left one question

x-pack/plugins/security_solution/public/management/links.ts

x-pack/plugins/security_solution/public/resolver/view/panels/node_list.tsx

paul-tavares

Changes to x-pack/plugins/security_solution/public/management/links.ts looks good 👍

x-pack/plugins/security_solution/public/entity_analytics/api/api.ts

.../entity_analytics/components/asset_criticality_file_uploader/components/file_picker_step.tsx

x-pack/plugins/security_solution/public/entity_analytics/routes.tsx

hop-dev

Great work 🚀

...urity_solution/public/entity_analytics/components/asset_criticality_file_uploader/reducer.ts

tiansivive

LGTM

Just a few small comments/thoughts

...ublic/entity_analytics/components/asset_criticality_file_uploader/components/result_step.tsx

...c/entity_analytics/components/asset_criticality_file_uploader/components/validation_step.tsx

...y_solution/public/entity_analytics/components/asset_criticality_file_uploader/validations.ts

x-pack/plugins/security_solution/public/resolver/view/panels/node_list.tsx

michaelolo24

Investigations changes! Mostly telemetry changes on our side. Nice work!

e40pud

DE changes LGTM

kibana-ci · 2024-04-12T11:56:57Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	5374	5387	+13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lists`	139.0KB	139.0KB	+46.0B
`securitySolution`	17.2MB	17.2MB	+42.3KB
total			+42.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	405.5KB	405.6KB	+46.0B
`securitySolution`	75.4KB	77.3KB	+1.9KB
`securitySolutionEss`	15.2KB	15.3KB	+77.0B
`securitySolutionServerless`	18.8KB	18.9KB	+77.0B
total			+2.1KB

History

💔 Build #203171 failed 515714c
💔 Build #202925 failed 8006df9
💔 Build #202883 failed 38c5603
💛 Build #202036 was flaky ae893bf
💔 Build #201832 failed 00c11583a9beb4293c64628f1e129af051712e45

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

benironside

UI copy looks good

…nd permissions (#180771) ## Summary Related to #179891 * Display error message in case user doesn't have write access to asset criticality index ![Screenshot 2024-04-15 at 14 34 17](https://github.com/elastic/kibana/assets/1490444/9d92fe32-26cd-4c22-be0f-951f2a719c2b) * Display error message if the user navigates to the page when the user advanced (UI) setting is disabled ![Screenshot 2024-04-15 at 14 32 35](https://github.com/elastic/kibana/assets/1490444/1ef5a079-de19-40c7-b378-30f707483e99) * Remove links from menus and global search if advanced (UI) setting is disabled ![Screenshot 2024-04-15 at 14 40 35](https://github.com/elastic/kibana/assets/1490444/0342aeba-8a45-457e-958d-0e65bcc7cd80) Recoding of what happens when you don't refresh the page: https://github.com/elastic/kibana/assets/1490444/2b67403c-d58e-4d92-b12d-9f9de4c9a213 ### Expected behaviour: * After the setting is enabled, the user needs to refresh the browser to find the page * If users disable the setting on a different browser/tab and navigate to the page without refreshing, they will see an error message on the page. * If users disable the flag while the page is already rendered and try to upload the file, it will display an error on the last step. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>

machadoum force-pushed the siem-ea-9047 branch from 3deed87 to 00c1158 Compare April 8, 2024 14:22

machadoum self-assigned this Apr 8, 2024

machadoum added the ci:cloud-deploy Create or update a Cloud deployment label Apr 8, 2024

machadoum force-pushed the siem-ea-9047 branch from 00c1158 to 52e3082 Compare April 8, 2024 14:26

machadoum added the ci:cloud-persist-deployment Persist cloud deployment indefinitely label Apr 9, 2024

machadoum and others added 13 commits April 11, 2024 10:51

Create a proof of concept to determine CSV parsing feasibility on cli…

8e15b90

…ent-side

Improve first step

7867e32

Improve errors and rename asset classification to criticality

462ad83

Update example message

451dae9

Refactor and added some template tests

b5f53d9

Add last unit tests

0a8fd96

Add asset criticality documentation link

f7b2341

Change column order on docs

ceee31c

Update translations

adc63fb

Update UI to match new types for AssetCriticalityCsvUploadResponse

5623014

Add cypress test

b1b2eb7

Update one more copy

04aec07

Add telemetry

22d3ddf

machadoum force-pushed the siem-ea-9047 branch from 47e18fc to 22d3ddf Compare April 11, 2024 08:54

machadoum changed the title ~~Siem ea 9047~~ [SecuritySolutions] Create Asset Criticality CSV upload page Apr 11, 2024

machadoum added 3 commits April 11, 2024 13:06

Improve reducer state type

00d95aa

Self code review improvements

781624a

Fix foolish errors

38c5603

machadoum marked this pull request as ready for review April 11, 2024 13:37

machadoum requested review from a team as code owners April 11, 2024 13:37

machadoum added the Team:Entity Analytics Security Entity Analytics Team label Apr 11, 2024

pzl requested review from paul-tavares and removed request for pzl April 11, 2024 13:38

tomsonpl approved these changes Apr 11, 2024

View reviewed changes

x-pack/plugins/security_solution/public/management/links.ts Outdated Show resolved Hide resolved

machadoum commented Apr 11, 2024

View reviewed changes

x-pack/plugins/security_solution/public/resolver/view/panels/node_list.tsx Show resolved Hide resolved

paul-tavares approved these changes Apr 11, 2024

View reviewed changes

Code review improvements 1 of 999

5007db5

hop-dev reviewed Apr 11, 2024

View reviewed changes

machadoum added 3 commits April 11, 2024 16:27

Fix CI

effe9ed

Code review improvements 2 of 999

8f0b160

Fix CI 2

8006df9

hop-dev approved these changes Apr 11, 2024

View reviewed changes

...urity_solution/public/entity_analytics/components/asset_criticality_file_uploader/reducer.ts Show resolved Hide resolved

tiansivive approved these changes Apr 11, 2024

View reviewed changes

michaelolo24 approved these changes Apr 12, 2024

View reviewed changes

jaredburgettelastic mentioned this pull request Apr 12, 2024

[Request] Update docs for asset criticality file upload capability elastic/security-docs#5085

Closed

e40pud approved these changes Apr 12, 2024

View reviewed changes

machadoum added 3 commits April 12, 2024 11:32

Code review improvement + fix broken cy test

0b2b8fc

Merge remote-tracking branch 'kibana/main' into siem-ea-9047

515714c

Fix CI

21f2fbc

machadoum enabled auto-merge (squash) April 12, 2024 12:19

natasha-moore-elastic mentioned this pull request Apr 12, 2024

[UI copy]: Automate the asset classification process from an offline data source elastic/security-docs#5070

Closed

benironside approved these changes Apr 12, 2024

View reviewed changes

machadoum merged commit 79096be into elastic:main Apr 12, 2024
39 checks passed

kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Apr 12, 2024

machadoum mentioned this pull request Apr 15, 2024

[SecuritySolutions] Update asset criticality upload page visibility and permissions #180771

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SecuritySolutions] Create Asset Criticality CSV upload page #179891

[SecuritySolutions] Create Asset Criticality CSV upload page #179891

machadoum commented Apr 3, 2024 •

edited

Loading

machadoum commented Apr 8, 2024

machadoum commented Apr 9, 2024

machadoum commented Apr 11, 2024

elasticmachine commented Apr 11, 2024

elasticmachine commented Apr 11, 2024

tomsonpl left a comment

paul-tavares left a comment

hop-dev left a comment

tiansivive left a comment

michaelolo24 left a comment

e40pud left a comment

kibana-ci commented Apr 12, 2024 •

edited

Loading

benironside left a comment

[SecuritySolutions] Create Asset Criticality CSV upload page #179891

[SecuritySolutions] Create Asset Criticality CSV upload page #179891

Conversation

machadoum commented Apr 3, 2024 • edited Loading

Summary

File picker Step:

File validation step

Result step

Checklist

How to test it?

What is not included?

Code owners files:

machadoum commented Apr 8, 2024

machadoum commented Apr 9, 2024

machadoum commented Apr 11, 2024

elasticmachine commented Apr 11, 2024

elasticmachine commented Apr 11, 2024

tomsonpl left a comment

Choose a reason for hiding this comment

paul-tavares left a comment

Choose a reason for hiding this comment

hop-dev left a comment

Choose a reason for hiding this comment

tiansivive left a comment

Choose a reason for hiding this comment

michaelolo24 left a comment

Choose a reason for hiding this comment

e40pud left a comment

Choose a reason for hiding this comment

kibana-ci commented Apr 12, 2024 • edited Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

benironside left a comment

Choose a reason for hiding this comment

machadoum commented Apr 3, 2024 •

edited

Loading

kibana-ci commented Apr 12, 2024 •

edited

Loading