[Security Solution] Create new host flyout #173392

machadoum · 2023-12-14T14:43:54Z

Summary

Create the Expandable Host flyout with the risk inputs panel.

What is included

Host panel creation
Left risk inputs panel
Refactor user panel component to be reused by Host
Risk score section

What is not included

Asset integration section
Asset criticality

How to test it?

Enable experimental flag newHostDetailsFlyout
Create alerts with host.name field
Open the alerts page and click on the host.name field
It should not display the expandable risk input panel
Enable Risk engine
make sure it generates data for the host
Open the flyout once more and check if the expandable risk input panel opens

* Refactor user flyout components to be reused by hosts

x-pack/plugins/security_solution/public/flyout/entity_details/host_right/content.tsx

Adapt risk summary to both entity flyouts

PhilippeOberti

LGTM for the Threat Hunting Investigations team

...ns/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.tsx

x-pack/plugins/security_solution/common/utility_types.ts

semd

Explore code LGTM

hop-dev · 2024-01-04T09:04:33Z

@elasticmachine merge upstream

.../security_solution/public/flyout/entity_details/host_right/fields/endpoint_policy_fields.tsx

tiansivive

LGTM, other than some minor nits

But since I worked on this feature, someone else from @elastic/security-entity-analytics should also take a look for final approval

.../security_solution/public/flyout/entity_details/host_right/hooks/use_observed_host_fields.ts

tiansivive · 2024-01-04T11:02:01Z

.../security_solution/public/flyout/entity_details/host_right/hooks/use_observed_host_fields.ts

+    [mlCapabilities]
+  );
+
+  if (!hostData.details) return [];


NIT: I've been constantly reminded in reviews that standard practice is to never return without braces in if checks 😆

Sergi also asked me to fix that. I am updating it everywhere. But I think it is weird that we have a code style preference that isn't included in the code style CI check (prettier).

I agree we should either have a lint rule for this or not care, I quite like it without the braces 😅

Yeah, I definitely agree, I asked the same, about having a lint rule.
I much prefer it without the braces, but if it's standard practice, we should have rule because I will definitely keep forgetting about it

x-pack/plugins/security_solution/public/flyout/entity_details/mocks/index.ts

...ns/security_solution/public/flyout/entity_details/shared/components/entity_table/columns.tsx

...plugins/security_solution/public/flyout/entity_details/user_right/hooks/use_observed_user.ts

...s/security_solution/public/flyout/entity_details/user_right/hooks/use_observed_user_items.ts

.../plugins/security_solution/public/timelines/components/timeline/body/renderers/host_name.tsx

.../security_solution/public/flyout/entity_details/host_right/hooks/use_observed_host_fields.ts

ES returns formatted strings by default.

kibana-ci · 2024-01-04T14:59:58Z

💛 Build succeeded, but was flaky

Failed CI Steps

FTR Configs #75

Test Failures

[job] [logs] FTR Configs #75 / transform - feature controls "after all" hook in "transform - feature controls"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	4842	4858	+16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	11.3MB	11.3MB	+12.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	64.2KB	64.2KB	+24.0B

History

💛 Build #185786 was flaky c86a695
💛 Build #185571 was flaky ed78043
💔 Build #185478 failed f8d96de
💔 Build #185455 failed 1aa2bca6a37f19b286b6cd896b181eed16ace8e3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum @tiansivive

## Summary issue: #173392 Flaky test runner runs: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4773 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4841 * Add cypress test to the new User and Host flyouts. * Fix function using the wrong host risk score index * Fix some cypress flakiness ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]>

## Summary issue: elastic#173392 Flaky test runner runs: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4773 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4841 * Add cypress test to the new User and Host flyouts. * Fix function using the wrong host risk score index * Fix some cypress flakiness ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]>

machadoum self-assigned this Dec 14, 2023

machadoum force-pushed the siem-ea-8084 branch from a41c98c to c778935 Compare December 18, 2023 09:02

machadoum changed the title ~~[Security Solution] Co-locate Frontend Entity Analytics Code~~ [Security Solution] Create new host flyout and show a 'Risk Summary' view Dec 18, 2023

machadoum force-pushed the siem-ea-8084 branch from e52e022 to fb2ad7c Compare December 21, 2023 13:00

Create new host details flyout

32a45ba

* Refactor user flyout components to be reused by hosts

machadoum force-pushed the siem-ea-8084 branch from fcc3e4b to 32a45ba Compare December 21, 2023 16:15

machadoum commented Dec 22, 2023

View reviewed changes

x-pack/plugins/security_solution/public/flyout/entity_details/host_right/content.tsx Outdated Show resolved Hide resolved

machadoum changed the title ~~[Security Solution] Create new host flyout and show a 'Risk Summary' view~~ [Security Solution] Create new host flyout Dec 22, 2023

machadoum force-pushed the siem-ea-8084 branch from 85a8b6b to b993b8a Compare December 22, 2023 12:30

Fix tests

5d29c5d

machadoum force-pushed the siem-ea-8084 branch from b993b8a to 5d29c5d Compare December 22, 2023 13:44

tiansivive and others added 7 commits January 1, 2024 20:33

adapt risk summary to both entity flyouts

d3db40e

opening panel

9b10b2e

Add more tests and fix storybook

a46a57e

Merge pull request #5 from tiansivive/siem-ea-8084-risk-summary

034cca0

Adapt risk summary to both entity flyouts

Merge remote-tracking branch 'elastic/main' into siem-ea-8084

884d606

Improve entity type check

80f6141

Fix host panel content storybook

beb285c

machadoum marked this pull request as ready for review January 2, 2024 13:40

machadoum requested review from a team as code owners January 2, 2024 13:40

machadoum assigned tiansivive Jan 2, 2024

machadoum removed the technical debt Improvement of the software architecture and operational architecture label Jan 2, 2024

machadoum force-pushed the siem-ea-8084 branch from 5849ca8 to 3337336 Compare January 2, 2024 15:34

PhilippeOberti approved these changes Jan 2, 2024

View reviewed changes

Fix small bugs and improve tests

6bed3c0

machadoum force-pushed the siem-ea-8084 branch from 1aa2bca to 6bed3c0 Compare January 2, 2024 16:52

kibanamachine and others added 2 commits January 2, 2024 17:00

[CI] Auto-commit changed files from 'node scripts/notice'

f8d96de

Update translations

ed78043

semd reviewed Jan 3, 2024

View reviewed changes

...ns/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.tsx Outdated Show resolved Hide resolved

semd reviewed Jan 3, 2024

View reviewed changes

x-pack/plugins/security_solution/common/utility_types.ts Show resolved Hide resolved

semd approved these changes Jan 3, 2024

View reviewed changes

oatkiller requested a review from dr3nkrypted January 3, 2024 18:37

Imrpove code and comments

e89111d

Merge branch 'main' into siem-ea-8084

c86a695

machadoum mentioned this pull request Jan 4, 2024

[Security Solution] Add cypress tests to entity flyouts #174232

Merged

1 task

tiansivive reviewed Jan 4, 2024

View reviewed changes

.../security_solution/public/flyout/entity_details/host_right/fields/endpoint_policy_fields.tsx Outdated Show resolved Hide resolved

tiansivive reviewed Jan 4, 2024

View reviewed changes

hop-dev approved these changes Jan 4, 2024

View reviewed changes

.../plugins/security_solution/public/timelines/components/timeline/body/renderers/host_name.tsx Outdated Show resolved Hide resolved

.../security_solution/public/flyout/entity_details/host_right/hooks/use_observed_host_fields.ts Outdated Show resolved Hide resolved

machadoum added 2 commits January 4, 2024 14:19

Please code review

b9725ea

Update mock risk score timestamp fields to formatted string

79bdc7b

ES returns formatted strings by default.

machadoum enabled auto-merge (squash) January 4, 2024 13:55

machadoum merged commit effd9e7 into elastic:main Jan 4, 2024

kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Create new host flyout #173392

[Security Solution] Create new host flyout #173392

machadoum commented Dec 14, 2023 •

edited

Loading

PhilippeOberti left a comment

semd left a comment

hop-dev commented Jan 4, 2024

tiansivive left a comment

tiansivive Jan 4, 2024

machadoum Jan 4, 2024

hop-dev Jan 4, 2024

tiansivive Jan 4, 2024

kibana-ci commented Jan 4, 2024

[Security Solution] Create new host flyout #173392

[Security Solution] Create new host flyout #173392

Conversation

machadoum commented Dec 14, 2023 • edited Loading

Summary

What is included

What is not included

How to test it?

PhilippeOberti left a comment

Choose a reason for hiding this comment

semd left a comment

Choose a reason for hiding this comment

hop-dev commented Jan 4, 2024

tiansivive left a comment

Choose a reason for hiding this comment

tiansivive Jan 4, 2024

Choose a reason for hiding this comment

machadoum Jan 4, 2024

Choose a reason for hiding this comment

hop-dev Jan 4, 2024

Choose a reason for hiding this comment

tiansivive Jan 4, 2024

Choose a reason for hiding this comment

kibana-ci commented Jan 4, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

machadoum commented Dec 14, 2023 •

edited

Loading