Skip to content

Commit

Permalink
[npmrc] Fix puppeteer_skip_download configuration (#177673)
Browse files Browse the repository at this point in the history
This was a breaking change introduced in puppeteer 20 See
puppeteer/puppeteer@df4d60c
  • Loading branch information
jbudz authored Feb 23, 2024
1 parent 7745d36 commit 42c0e28
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion .buildkite/scripts/steps/bazel_cache/bootstrap_linux.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ source .buildkite/scripts/common/util.sh

export BAZEL_CACHE_MODE=populate-local-gcs
export DISABLE_BOOTSTRAP_VALIDATION=true
export PUPPETEER_SKIP_DOWNLOAD=true

# Clear out bazel cache between runs to make sure that any artifacts that don't exist in the cache are uploaded
rm -rf ~/.bazel-cache
Expand Down
1 change: 0 additions & 1 deletion .buildkite/scripts/steps/bazel_cache/bootstrap_mac.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ source .buildkite/scripts/common/util.sh

export BAZEL_CACHE_MODE=populate-local-gcs
export DISABLE_BOOTSTRAP_VALIDATION=true
export PUPPETEER_SKIP_CHROME_DOWNLOAD=true

# Because we're manually deleting node_modules and bazel directories in-between runs, we need to --force-install
export BOOTSTRAP_ALWAYS_FORCE_INSTALL=true
Expand Down
2 changes: 1 addition & 1 deletion .npmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
puppeteer_skip_chromium_download=true
puppeteer_skip_download=true

0 comments on commit 42c0e28

Please sign in to comment.