-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerization #115
Open
kares
wants to merge
24
commits into
elastic:master
Choose a base branch
from
kares:dock+update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dockerization #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for predictability -> so we could bundle install --deployment
to avoid loading issues ...
FATAL: Something went wrong with the `I18n.translate`, please verify your keys or string, exception: C.UTF-8.lita.config.type_error>, locale: C.UTF-8, key: lita.config.type_error, options: {:attribute=>:token, :types=>"String"}
lita-slack being a plugin and us not having Gemfile declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is an dockerization effort for running Jarvis.
Jarvis uses Lita which depends on Redis being present on
localhost:6379
.We're using the legacy
network_mode: host
to be able to run a single Docker image,alternatively a docker-compose.yml is present with another image exposing Redis to localhost.
Jarvis was running on MRI but assumes some of it's external process (plugin publishing) task to be run with JRuby.
The duality is maintained and both Rubies are installed in the generated image, the default Ruby being JRuby.
The resulting image depends on 3 (private) tokens provided from as environment variables for it's operations:
SLACK_TOKEN
GITHUB_TOKEN
GEM_HOST_API_KEY
p.s. Lita has been upgraded from 4.7.1 (that was running previously on AWS) to latest 4.8.0.