-
Notifications
You must be signed in to change notification settings - Fork 456
[Cribl] Fix handling of metric event type #13930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit and a question, but overall LGTM
packages/cribl/data_stream/metrics/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
Co-authored-by: Kylie Meli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like CI failure is related to README update. Can you please check?
got | 0s
-- | --
| @@ -44,3 +44,3 @@
|
| - 2. Set **Index or Data Stream** to `logs-cribl-default` for log-type events and to `metrics-cribl-default` for metric-type events.
| + 2. Set **Index or Data Stream** to `logs-cribl-default` for log-type events or to `metrics-cribl-default` for metric-type events.
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Package cribl - 0.5.1 containing this change is available at https://epr.elastic.co/package/cribl/0.5.1/ |
Proposed commit message
Checklist
changelog.yml
file.Related issues