Skip to content

[Cribl] Fix handling of metric event type #13930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025

Conversation

moxarth-rathod
Copy link
Contributor

@moxarth-rathod moxarth-rathod commented May 19, 2025

Proposed commit message

cribl: reroute to metrics datastreams

Updated the documentation to specify separate index templates for logs and metrics
and added a dedicated metrics pipeline, ensuring correct handling of metric events.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@moxarth-rathod moxarth-rathod self-assigned this May 19, 2025
@moxarth-rathod moxarth-rathod requested a review from a team as a code owner May 19, 2025 10:38
@moxarth-rathod moxarth-rathod added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:cribl Cribl Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels May 19, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy requested a review from kgeller May 20, 2025 15:13
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit and a question, but overall LGTM

Co-authored-by: Kylie Meli <[email protected]>
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI failure is related to README update. Can you please check?


got | 0s
-- | --
  | @@ -44,3 +44,3 @@
  |  
  | -    2. Set **Index or Data Stream** to `logs-cribl-default` for log-type events and to `metrics-cribl-default` for metric-type events.
  | +    2. Set **Index or Data Stream** to `logs-cribl-default` for log-type events or to `metrics-cribl-default` for metric-type events.



@moxarth-rathod moxarth-rathod requested a review from kcreddy May 23, 2025 05:24
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @moxarth-rathod

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kcreddy kcreddy merged commit a7bf37b into elastic:main May 23, 2025
7 of 8 checks passed
@elastic-vault-github-plugin-prod

Package cribl - 0.5.1 containing this change is available at https://epr.elastic.co/package/cribl/0.5.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:cribl Cribl Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cribl] reroute to metrics datastreams
4 participants