feat(oidc): for using EC credentials #13926
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
alert |
1569.86 | 1288.66 | -281.2 (-17.91%) | 💔 |
vulnerability |
3802.28 | 2994.01 | -808.27 (-21.26%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
test serverless |
* main: (42 commits) [jamf_pro] Fix `flattened` field types for non-object values (elastic#13985) [Netskope Alerts] Add text multi-field to netskope.alerts.breach.description field (elastic#13977) zscaler_zia: add strict field template mode for tcp and http_endpoint input data streams (elastic#13904) apm: Add config for tail-based sampling discard on write (elastic#13950) [CI] Add dev/coverage into backport script (elastic#13987) Update configuration updatecli for 8.x snapshot (elastic#13981) [Prometheus] Add username, password, and SSL related fields for query dataset (elastic#13969) o365: Ignore failures in rename processors for organization fields (elastic#13983) aws.firewall: Document ingested log types of AWS Network Firewall (elastic#13978) mimecast: resolve field data type conflicts between data streams (elastic#13825) [Infoblox NIOS] Handle the parsing of IPv6 address (elastic#13947) [Cribl] Fix handling of metric event type (elastic#13930) zscaler_zpa: fix handling of multiple remote IPs, and event categorisation (elastic#13755) Adding agentless deployment to the sublime security integration (elastic#13963) [integration/system] add use_performance_counters in system integration (elastic#13150) crowdstrike,m365_defender,microsoft_defender_{cloud,endpoint},sentinel_one: normalise severity handling (elastic#13955) [forgerock] Map `forgerock.response.elapsedTime` as a long not a date (elastic#13959) github: squelch errors from pagination ends (elastic#13965) cisco_secure_endpoint: squelch errors from pagination ends (elastic#13964) [Cloud Security] Cloud Asset Inventory: fixed cloud formation URL (elastic#13971) ...
💛 Build succeeded, but was flaky
Failed CI Steps
History
cc @v1v |
v1v
commented
May 26, 2025
| - avaly/gcp-secret-manager#v1.2.0: | ||
| env: | ||
| EC_API_KEY: elastic-cloud-observability-team-qa-api-key | ||
| EC_HOST: elastic-cloud-observability-team-qa-endpoint |
There was a problem hiding this comment.
I think this secret is not really a secret, shall we use the value instead?
There was a problem hiding this comment.
When this feature was implemented, I was not totally sure if that URL should be public or not. That's why I added that as a secret.
|
v1v
commented
May 26, 2025
mrodm
approved these changes
May 27, 2025
| - avaly/gcp-secret-manager#v1.2.0: | ||
| env: | ||
| EC_API_KEY: elastic-cloud-observability-team-qa-api-key | ||
| EC_HOST: elastic-cloud-observability-team-qa-endpoint |
There was a problem hiding this comment.
When this feature was implemented, I was not totally sure if that URL should be public or not. That's why I added that as a secret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Use the google secrets to fetch the EC credentials we provide and they are ephemeral.
Use https://github.com/avaly/gcp-secret-manager-buildkite-plugin.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
In the CI, see this build based on https://github.com/elastic/integrations/tree/test/use-google-secrets
Related issues
Screenshots