feat(oidc): for using EC credentials #13926

v1v · 2025-05-16T22:09:14Z

Proposed commit message

Use the google secrets to fetch the EC credentials we provide and they are ephemeral.

Use https://github.com/avaly/gcp-secret-manager-buildkite-plugin.

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.
I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

[ ]

How to test this PR locally

In the CI, see this build based on https://github.com/elastic/integrations/tree/test/use-google-secrets

Related issues

Screenshots

elastic-vault-github-plugin-prod · 2025-05-16T23:49:50Z

🚀 Benchmarks report

Package `crowdstrike` 👍(3) 💚(0) 💔(2)

Expand to view

Data stream	Previous EPS	New EPS	Diff (%)	Result
`alert`	1569.86	1288.66	-281.2 (-17.91%)	💔
`vulnerability`	3802.28	2994.01	-808.27 (-21.26%)	💔

To see the full report comment with /test benchmark fullreport

v1v · 2025-05-19T07:43:31Z

test serverless

* main: (42 commits) [jamf_pro] Fix `flattened` field types for non-object values (elastic#13985) [Netskope Alerts] Add text multi-field to netskope.alerts.breach.description field (elastic#13977) zscaler_zia: add strict field template mode for tcp and http_endpoint input data streams (elastic#13904) apm: Add config for tail-based sampling discard on write (elastic#13950) [CI] Add dev/coverage into backport script (elastic#13987) Update configuration updatecli for 8.x snapshot (elastic#13981) [Prometheus] Add username, password, and SSL related fields for query dataset (elastic#13969) o365: Ignore failures in rename processors for organization fields (elastic#13983) aws.firewall: Document ingested log types of AWS Network Firewall (elastic#13978) mimecast: resolve field data type conflicts between data streams (elastic#13825) [Infoblox NIOS] Handle the parsing of IPv6 address (elastic#13947) [Cribl] Fix handling of metric event type (elastic#13930) zscaler_zpa: fix handling of multiple remote IPs, and event categorisation (elastic#13755) Adding agentless deployment to the sublime security integration (elastic#13963) [integration/system] add use_performance_counters in system integration (elastic#13150) crowdstrike,m365_defender,microsoft_defender_{cloud,endpoint},sentinel_one: normalise severity handling (elastic#13955) [forgerock] Map `forgerock.response.elapsedTime` as a long not a date (elastic#13959) github: squelch errors from pagination ends (elastic#13965) cisco_secure_endpoint: squelch errors from pagination ends (elastic#13964) [Cloud Security] Cloud Asset Inventory: fixed cloud formation URL (elastic#13971) ...

elasticmachine · 2025-05-26T08:50:01Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: ca8359e

Failed CI Steps

History

💛 Build #26022 was flaky 7e15a13

cc @v1v

v1v · 2025-05-26T09:58:51Z

.buildkite/pipeline.serverless.yml

+      - avaly/gcp-secret-manager#v1.2.0:
+          env:
+            EC_API_KEY: elastic-cloud-observability-team-qa-api-key
+            EC_HOST: elastic-cloud-observability-team-qa-endpoint


I think this secret is not really a secret, shall we use the value instead?

When this feature was implemented, I was not totally sure if that URL should be public or not. That's why I added that as a secret.

If possible I think it would be interesting to keep both values as secrets. It would be quick to change and both values are in the same location.

elastic-sonarqube · 2025-05-26T10:00:16Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

.buildkite/hooks/pre-command

mrodm · 2025-05-27T14:44:39Z

.buildkite/pipeline.serverless.yml

+      - avaly/gcp-secret-manager#v1.2.0:
+          env:
+            EC_API_KEY: elastic-cloud-observability-team-qa-api-key
+            EC_HOST: elastic-cloud-observability-team-qa-endpoint


When this feature was implemented, I was not totally sure if that URL should be public or not. That's why I added that as a secret.

.buildkite/hooks/pre-command

v1v · 2025-05-29T10:04:41Z

@Mergifyio backport backport-security_detection_engine-8.18 backport-security_detection_engine-8.17

mergify · 2025-05-29T10:04:52Z

backport backport-security_detection_engine-8.18 backport-security_detection_engine-8.17

✅ Backports have been created

#14057 [backport-security_detection_engine-8.18] (backport #13926) feat(oidc): for using EC credentials has been created for branch backport-security_detection_engine-8.18
#14058 [backport-security_detection_engine-8.17] (backport #13926) feat(oidc): for using EC credentials has been created for branch backport-security_detection_engine-8.17

(cherry picked from commit d20ee73)

v1v · 2025-05-29T10:07:07Z

PENDING BACKPORTS

mrodm · 2025-05-29T11:52:25Z

PENDING BACKPORTS

backport-cloud_security_posture-1.13

backport-security_detection_engine-8.16

backport-crowdstrike-1.52

backport-ti_abusech-2.6

backport-crowdstrike-1.46 backport-aws-2.30`

@v1v please backport these changes to this branch too: backport-apm-8.15 🙏
It was created a few hours ago too, and probably that branch would be used in the future too.

Thanks!

v1v · 2025-05-29T12:07:41Z

@Mergifyio backport backport-apm-8.15 backport-cloud_security_posture-1.13

mergify · 2025-05-29T12:07:48Z

backport backport-apm-8.15 backport-cloud_security_posture-1.13

✅ Backports have been created

#14059 [backport-apm-8.15] (backport #13926) feat(oidc): for using EC credentials has been created for branch backport-apm-8.15
#14060 [backport-cloud_security_posture-1.13] (backport #13926) feat(oidc): for using EC credentials has been created for branch backport-cloud_security_posture-1.13

(cherry picked from commit d20ee73)

v1v · 2025-05-29T12:48:00Z

@Mergifyio backport backport-security_detection_engine-8.16 backport-crowdstrike-1.52

mergify · 2025-05-29T12:48:14Z

backport backport-security_detection_engine-8.16 backport-crowdstrike-1.52

✅ Backports have been created

#14061 [backport-security_detection_engine-8.16] (backport #13926) feat(oidc): for using EC credentials has been created for branch backport-security_detection_engine-8.16
#14062 [backport-crowdstrike-1.52] (backport #13926) feat(oidc): for using EC credentials has been created for branch backport-crowdstrike-1.52

(cherry picked from commit d20ee73)

v1v · 2025-05-29T13:21:53Z

@Mergifyio backport backport-ti_abusech-2.6 backport-crowdstrike-1.46

mergify · 2025-05-29T13:22:25Z

backport backport-ti_abusech-2.6 backport-crowdstrike-1.46

✅ Backports have been created

#14063 [backport-ti_abusech-2.6] (backport #13926) feat(oidc): for using EC credentials has been created for branch backport-ti_abusech-2.6
#14064 [backport-crowdstrike-1.46] (backport #13926) feat(oidc): for using EC credentials has been created for branch backport-crowdstrike-1.46 but encountered conflicts

(cherry picked from commit d20ee73)

(cherry picked from commit d20ee73) # Conflicts: # .buildkite/pipeline.serverless.yml

feat(oidc): for using EC credentials

7e15a13

v1v added 2 commits May 26, 2025 10:31

use -ci account

ca8359e

v1v commented May 26, 2025

View reviewed changes

v1v self-assigned this May 26, 2025

v1v requested review from a team May 26, 2025 10:00

v1v marked this pull request as ready for review May 26, 2025 10:00

v1v requested a review from a team as a code owner May 26, 2025 10:00

v1v commented May 26, 2025

View reviewed changes

.buildkite/hooks/pre-command Show resolved Hide resolved

v1v mentioned this pull request May 26, 2025

buildkite(oidc): access google secrets for the ECH elastic/elastic-package#2612

Merged

mrodm approved these changes May 27, 2025

View reviewed changes

v1v merged commit d20ee73 into elastic:main May 29, 2025
8 checks passed

mergify bot pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926)

c31261d

(cherry picked from commit d20ee73)

mergify bot mentioned this pull request May 29, 2025

[backport-security_detection_engine-8.18] (backport #13926) feat(oidc): for using EC credentials #14057

Merged

5 tasks

mergify bot pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926)

96665fa

(cherry picked from commit d20ee73)

mergify bot mentioned this pull request May 29, 2025

[backport-security_detection_engine-8.17] (backport #13926) feat(oidc): for using EC credentials #14058

Merged

5 tasks

mergify bot pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926)

9959aeb

(cherry picked from commit d20ee73)

mergify bot mentioned this pull request May 29, 2025

[backport-apm-8.15] (backport #13926) feat(oidc): for using EC credentials #14059

Merged

5 tasks

mergify bot pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926)

3761107

(cherry picked from commit d20ee73)

mergify bot mentioned this pull request May 29, 2025

[backport-cloud_security_posture-1.13] (backport #13926) feat(oidc): for using EC credentials #14060

Merged

5 tasks

mergify bot pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926)

258d9bb

(cherry picked from commit d20ee73)

mergify bot mentioned this pull request May 29, 2025

[backport-security_detection_engine-8.16] (backport #13926) feat(oidc): for using EC credentials #14061

Merged

5 tasks

mergify bot pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926)

fbc9c07

(cherry picked from commit d20ee73)

mergify bot mentioned this pull request May 29, 2025

[backport-crowdstrike-1.52] (backport #13926) feat(oidc): for using EC credentials #14062

Merged

5 tasks

mergify bot pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926)

3e83bcb

(cherry picked from commit d20ee73)

mergify bot mentioned this pull request May 29, 2025

[backport-ti_abusech-2.6] (backport #13926) feat(oidc): for using EC credentials #14063

Merged

5 tasks

mergify bot pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926)

ef1e92b

(cherry picked from commit d20ee73) # Conflicts: # .buildkite/pipeline.serverless.yml

mergify bot mentioned this pull request May 29, 2025

[backport-crowdstrike-1.46] (backport #13926) feat(oidc): for using EC credentials #14064

Closed

5 tasks

v1v pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926) (#14060)

b5ef185

v1v pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926) (#14062)

6279ca9

v1v pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926) (#14063)

7e28c45

v1v pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926) (#14061)

5e4b6fa

v1v pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926) (#14058)

30de43c

v1v pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926) (#14057)

c6507b9

v1v pushed a commit that referenced this pull request May 29, 2025

feat(oidc): for using EC credentials (#13926) (#14059)

ed21ff8

feat(oidc): for using EC credentials #13926

feat(oidc): for using EC credentials #13926

Uh oh!

Conversation

v1v commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed commit message

Checklist

Author's Checklist

How to test this PR locally

Related issues

Screenshots

Uh oh!

elastic-vault-github-plugin-prod bot commented May 16, 2025

🚀 Benchmarks report

Package crowdstrike 👍(3) 💚(0) 💔(2)

Uh oh!

v1v commented May 19, 2025

Uh oh!

elasticmachine commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💛 Build succeeded, but was flaky

Failed CI Steps

History

Uh oh!

v1v May 26, 2025

Choose a reason for hiding this comment

Uh oh!

mrodm May 27, 2025

Choose a reason for hiding this comment

Uh oh!

mrodm May 29, 2025

Choose a reason for hiding this comment

Uh oh!

elastic-sonarqube bot commented May 26, 2025

Quality Gate passed

Uh oh!

Uh oh!

mrodm May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

v1v commented May 29, 2025

Uh oh!

mergify bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

v1v commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PENDING BACKPORTS

Uh oh!

mrodm commented May 29, 2025

PENDING BACKPORTS

Uh oh!

v1v commented May 29, 2025

Uh oh!

mergify bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

v1v commented May 29, 2025

Uh oh!

mergify bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

v1v commented May 29, 2025

Uh oh!

mergify bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Uh oh!

v1v commented May 16, 2025 •

edited

Loading

Package `crowdstrike` 👍(3) 💚(0) 💔(2)

elasticmachine commented May 26, 2025 •

edited

Loading

mergify bot commented May 29, 2025 •

edited

Loading

v1v commented May 29, 2025 •

edited

Loading

mergify bot commented May 29, 2025 •

edited

Loading

mergify bot commented May 29, 2025 •

edited

Loading

mergify bot commented May 29, 2025 •

edited

Loading