-
Notifications
You must be signed in to change notification settings - Fork 455
[Apache_Tomcat] Ingest pipeline pattern enhancement #13896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/test |
🚀 Benchmarks reportTo see the full report comment with |
b482f9e
to
66265ac
Compare
@Linu-Elias : As per documentation %T also gives the same time just in seconds.. So are both same ? If yes, do we need both of them in the log format ? |
@ishleenk17, I was about to add a comment regarding a gap. |
Can we confirm on this from the apache tomcat logs and if required do the correction in the current code. |
I have made the necessary doc changes in this PR for- changed |
@@ -23,3 +23,7 @@ | |||
type: double | |||
description: Response time of the endpoint. | |||
unit: s | |||
- name: http.request.process_time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't this under the apache_tomcat.access fields ?
@@ -23,3 +23,7 @@ | |||
type: double | |||
description: Response time of the endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change the description of this field as you mentioned here.
#13896 (comment)
08cd592
to
a1ce6d5
Compare
@@ -22,3 +22,6 @@ | |||
- name: vol | |||
type: keyword | |||
description: The serial number of the volume that contains a file. (Windows-only) | |||
- name: log.flags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this added for ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build was failing because of missing field
test case failed: one or more errors found in mappings in logs-apache_tomcat.catalina index template: [0] field "log.flags" is undefined: field definition not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 last comment.
Otherwise looks good!
|
💚 Build Succeeded
History
cc @Linu-Elias |
Proposed commit message
Added support for %D attribute to get the time taken to process the request, in millis.
Existing Supported Pattern:
Common Log Format :- '%h %l %u %t "%r" %s %b'
Combined Log Format :- '%h %l %u %t "%r" %s %b "%{Referrer}i" "%{User-Agent}i"'
Combined Log Format + X-Forwarded-For header :- '%h %l %u %t "%r" %s %b %A %X %T "%{Referer}i" "%{User-Agent}i" X-Forwarded-For="%{X-Forwarded-For}i"'
New Pattern:
Common Log Format :- '%h %l %u %t "%r" %s %b ms:%D'
Combined Log Format :- '%h %l %u %t "%r" %s %b ms:%D "%{Referrer}i" "%{User-Agent}i"'
Combined Log Format + X-Forwarded-For header :- '%h %l %u %t "%r" %s %b ms:%D %A %X %T "%{Referer}i" "%{User-Agent}i" X-Forwarded-For="%{X-Forwarded-For}i"'
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots