Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoblox_nios: support AD authentication failure log messages and DHCPACK events without device names #12933

Merged
merged 5 commits into from
Mar 4, 2025
Merged

infoblox_nios: support AD authentication failure log messages and DHCPACK events without device names #12933

merged 5 commits into from
Mar 4, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 3, 2025 •
edited
Loading

Proposed commit message

infoblox_nios: support AD authentication failure log messages and DHCPACK events without device names

Also improve identifiability of failing processors.

Test case provided by user.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:infoblox_nios Infoblox NIOS Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Mar 3, 2025
@efd6 efd6 self-assigned this Mar 3, 2025
@efd6 efd6 force-pushed the 12730-infoblox_nios branch from e70f299 to 8ef0d69 Compare March 3, 2025 02:31
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review March 3, 2025 03:25
@efd6 efd6 requested a review from a team as a code owner March 3, 2025 03:25
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 changed the title infoblox_nios: support AD authentication failure log messages infoblox_nios: support AD authentication failure log messages and DHCPACK without device names Mar 4, 2025
@efd6 efd6 changed the title infoblox_nios: support AD authentication failure log messages and DHCPACK without device names infoblox_nios: support AD authentication failure log messages and DHCPACK events without device names Mar 4, 2025
@efd6 efd6 force-pushed the 12730-infoblox_nios branch from 4573fde to 93ddfd3 Compare March 4, 2025 20:57
@efd6 efd6 enabled auto-merge (squash) March 4, 2025 21:05
@efd6 efd6 merged commit f191f96 into elastic:main Mar 4, 2025
5 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #22946 succeeded 4573fde5d19beaee721c0bda695ad4517fcbfad1
  • 💚 Build #22879 succeeded 8ef0d699299eaf654abf93000a42e5e0eb9655d6

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
82.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elastic-vault-github-plugin-prod
Copy link

Package infoblox_nios - 1.29.0 containing this change is available at https://epr.elastic.co/package/infoblox_nios/1.29.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisberkhout chrisberkhout chrisberkhout approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:infoblox_nios Infoblox NIOS Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
3 participants
@efd6 @elasticmachine @chrisberkhout