Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[checkpoint] Extend key/value parsing and expand supported fields #12929

Merged
merged 2 commits into from
Mar 5, 2025
Merged

[checkpoint] Extend key/value parsing and expand supported fields #12929

merged 2 commits into from
Mar 5, 2025

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Feb 28, 2025 •
edited
Loading

Proposed commit message

  • Extend key/value parsing to include numbers in key names and extend supported fields.
  • Mapped checkpoint.hostname to host.hostname

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/checkpoint
elastic-package test

Related issues

@taylor-swanson
[checkpoint] Extend key/value parsing and expand supported fields
ab67729 
- Extend key/value parsing to include numbers in key names and extend supported fields.
- Mapped checkpoint.hostname to host.hostname
@taylor-swanson taylor-swanson added enhancement New feature or request Integration:checkpoint Check Point Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Feb 28, 2025
@taylor-swanson taylor-swanson self-assigned this Feb 28, 2025
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@taylor-swanson taylor-swanson marked this pull request as ready for review February 28, 2025 19:00
@taylor-swanson taylor-swanson requested a review from a team as a code owner February 28, 2025 19:00
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

dwhyrock
dwhyrock approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@dwhyrock dwhyrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the changelog link needs to be updated.

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @taylor-swanson

@taylor-swanson taylor-swanson merged commit 637377d into elastic:main Mar 5, 2025
7 checks passed
@taylor-swanson taylor-swanson deleted the enhance/checkpoint-mappings branch March 5, 2025 15:11
@elastic-vault-github-plugin-prod
Copy link

Package checkpoint - 1.38.0 containing this change is available at https://epr.elastic.co/package/checkpoint/1.38.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwhyrock dwhyrock dwhyrock approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
enhancement New feature or request Integration:checkpoint Check Point Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[checkpoint] Extend key/value parsing and expand supported fields
3 participants
@taylor-swanson @elasticmachine @dwhyrock