Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rubrik] Add sla_domains data stream #12923

Merged
merged 6 commits into from
Mar 1, 2025

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Feb 28, 2025

Overview

This PR adds the sla_domains data stream. It uses the Rubrik REST API to get data.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

image

@gpop63 gpop63 self-assigned this Feb 28, 2025
@gpop63 gpop63 added Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Integration:rubrik Rubrik RSC Metrics enhancement New feature or request labels Feb 28, 2025
@gpop63 gpop63 marked this pull request as ready for review February 28, 2025 12:12
@gpop63 gpop63 requested a review from a team as a code owner February 28, 2025 12:12
@gpop63 gpop63 changed the title [rubrik] Rdd sla_domains data stream [rubrik] Add sla_domains data stream Feb 28, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Feb 28, 2025

🚀 Benchmarks report

Package rubrik 👍(2) 💚(1) 💔(9)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
tasks 58823.53 27777.78 -31045.75 (-52.78%) 💔
virtual_machines 66666.67 40000 -26666.67 (-40%) 💔
filesets 18518.52 11904.76 -6613.76 (-35.71%) 💔
global_cluster_performance 18518.52 9433.96 -9084.56 (-49.06%) 💔
managed_volumes 25641.03 12820.51 -12820.52 (-50%) 💔
monitoring_jobs 41666.67 21739.13 -19927.54 (-47.83%) 💔
mssql_databases 43478.26 24390.24 -19088.02 (-43.9%) 💔
node_statistics 11904.76 7142.86 -4761.9 (-40%) 💔
physical_hosts 45454.55 22727.27 -22727.28 (-50%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @gpop63

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
53.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@devamanv devamanv merged commit c172eab into elastic:main Mar 1, 2025
6 of 7 checks passed
@elastic-vault-github-plugin-prod

Package rubrik - 0.7.0 containing this change is available at https://epr.elastic.co/package/rubrik/0.7.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:rubrik Rubrik RSC Metrics Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants