ti_crowdstrike: populate required threat.intelligence fields #12915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bugfix
efd6
force-pushed
the
12852-ti_crowdstrike
branch
2 times, most recently
from
fc82ad3 to
1a6adff
Compare
The Security Intelligence view Indicator is populated by logic in kibana[1,2], so make sure we match that logic to make sure the relevant value is visible. [1]https://github.com/elastic/kibana/blob/33c18c72fa019430c6b73503dc3176e0136e3861/x-pack/solutions/security/plugins/threat_intelligence/server/utils/indicator_name.ts#L19C1-L53C1 [2]https://github.com/elastic/kibana/blob/33c18c72fa019430c6b73503dc3176e0136e3861/x-pack/solutions/security/plugins/threat_intelligence/common/types/indicator.ts#L11-L51
efd6
force-pushed
the
12852-ti_crowdstrike
branch
from
1a6adff to
fe4622e
Compare
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy
approved these changes
Feb 28, 2025
Comment on lines
298
to
310
| } else if (ctx.ti_crowdstrike.ioc.type == 'md5') { | ||
| ctx.threat.indicator.file = ctx.threat.indicator.file ?: [:]; | ||
| ctx.threat.indicator.file.hash = ctx.threat.indicator.file.hash ?: [:]; | ||
| ctx.threat.indicator.file.hash.md5 = ctx.ti_crowdstrike?.ioc.value; | ||
| } else if (ctx.ti_crowdstrike.ioc.type == 'sha256') { | ||
| ctx.threat.indicator.file = ctx.threat.indicator.file ?: [:]; | ||
| ctx.threat.indicator.file.hash = ctx.threat.indicator.file.hash ?: [:]; | ||
| ctx.threat.indicator.file.hash.sha256 = ctx.ti_crowdstrike?.ioc.value; | ||
| } else if (ctx.ti_crowdstrike.ioc.type == 'sha1') { | ||
| ctx.threat.indicator.file = ctx.threat.indicator.file ?: [:]; | ||
| ctx.threat.indicator.file.hash = ctx.threat.indicator.file.hash ?: [:]; | ||
| ctx.threat.indicator.file.hash.sha1 = ctx.ti_crowdstrike?.ioc.value; | ||
| } |
There was a problem hiding this comment.
With this we could reduce few checks, but I will leave it to you.
if (mapping == 'file') {
ctx.threat.indicator.file = ctx.threat.indicator.file ?: [:];
ctx.threat.indicator.file.hash = ctx.threat.indicator.file.hash ?: [:];
}
There was a problem hiding this comment.
That's really nice. Thanks
efd6
force-pushed
the
12852-ti_crowdstrike
branch
from
cd50948 to
df11fca
Compare
💚 Build Succeeded
History
cc @efd6 |
|
kcreddy
approved these changes
Mar 3, 2025
|
Package ti_crowdstrike - 2.3.2 containing this change is available at https://epr.elastic.co/package/ti_crowdstrike/2.3.2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots