Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify 'content' in connector descriptions #12481

Closed
wants to merge 4 commits into from
Closed

Specify 'content' in connector descriptions #12481

wants to merge 4 commits into from

Conversation

seanstory
Copy link
Member

@seanstory seanstory commented Jan 27, 2025 •
edited
Loading

Proposed commit message

Adds a 'content sync' qualifier to the descriptions of Connector integrations, to align with 8.x descriptions that had been hardcoded in Kibana.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@seanstory seanstory added the enhancement New feature or request label Jan 27, 2025
@seanstory seanstory marked this pull request as ready for review January 27, 2025 15:40
@seanstory seanstory requested review from a team January 27, 2025 15:40
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@andrewkroh andrewkroh added Integration:elastic_connectors Elastic Connectors Team:Search-Extract and Transform Search - Extract and Transform [elastic/search-extract-and-transform] bugfix Pull request that fixes a bug issue and removed enhancement New feature or request labels Jan 27, 2025
@qcorporation qcorporation force-pushed the seanstory/add-content-to-descriptions branch from b4feee4 to 1b0d2a3 Compare February 3, 2025 22:34
@qcorporation qcorporation requested review from a team, rdner and mauri870 February 3, 2025 22:34
@andrewkroh andrewkroh added Integration:1password 1Password Integration:abnormal_security Abnormal Security New Integration Issue or pull request for creating a new integration package. Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Feb 3, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@qcorporation qcorporation force-pushed the seanstory/add-content-to-descriptions branch from 1b0d2a3 to c6551db Compare February 4, 2025 18:13
@elasticmachine
Copy link

⏳ Build in-progress, with failures

Failed CI Steps

History

@qcorporation qcorporation force-pushed the main branch 2 times, most recently from eda4138 to f728ca7 Compare February 5, 2025 22:00
@efd6
Copy link
Contributor

efd6 commented Feb 25, 2025

@seanstory Would you mind either syncing this with main or closing it? It is resulting in repeated notifications to multiple teams.

@seanstory
Copy link
Member Author

Sorry! I dropped the ball here. We can revisit at a later date.

@seanstory seanstory closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@rdner rdner Awaiting requested review from rdner rdner was automatically assigned from elastic/elastic-agent-data-plane

@mauri870 mauri870 Awaiting requested review from mauri870 mauri870 was automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
bugfix Pull request that fixes a bug issue Integration:elastic_connectors Elastic Connectors New Integration Issue or pull request for creating a new integration package. Team:Search-Extract and Transform Search - Extract and Transform [elastic/search-extract-and-transform] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seanstory @elasticmachine @efd6 @jsoriano @andrewkroh