Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add steps to configure a PGP key for agent upgrade #984
base: main
Are you sure you want to change the base?
Add steps to configure a PGP key for agent upgrade #984
Changes from all commits
08188fc
80e6075
ab5616f
ceadbd6
bcb1d38
f698c5e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few points to clarify:
default.pgp
bundled with Fleet Server?If it's bundled, air-gapped users are good to go with it.
default.pgp
downloaded lazily fromhttps://artifacts.elastic.co/GPG-KEY-elastic-agent
by default?If it is the case, then air-gapped users can grant access to it (HTTP Proxy or open the firewall).
default.php
downloaded lazily from the URL provided viaserver.pgp.upstream_url
setting?If it is the case, then air-gapped users can specify a URL so that it will be downloaded from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a lazy download from
server.pgp.upstream_url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be very clear:
No, on install this file does not exist; but a user can add it manually write the file on the instance if there is 0 internet access in order to distribute it to the agents
Yes, the default value of
server.pgp.upstream_url
ishttps://artifacts.elastic.co/GPG-KEY-elastic-agent
; ifdefault.pgp
is not on-disk when the key is requested, fleet-server will download the file from the upstream URL, save it to disk and serve ityes, see above 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michel-laterman I'm sorry to bring this one up again (I lost track of it and am doing some housekeeping now).
Is there anything I need to clarify in the text above, or do you think this is okay to merge as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so