Add custom settings page #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
juliaElastic
reviewed
Mar 6, 2024
juliaElastic
reviewed
Mar 6, 2024
juliaElastic
reviewed
Mar 6, 2024
juliaElastic
reviewed
Mar 6, 2024
|
Thanks @juliaElastic! Nice catches. I've addressed all comments in cfff910. |
karenzone
approved these changes
Mar 7, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Add custom settings page * Fixup * Fix whitespace; replace policy ID with placeholder (cherry picked from commit 4106015)
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Add custom settings page * Fixup * Fix whitespace; replace policy ID with placeholder (cherry picked from commit 4106015)
This was referenced Mar 7, 2024
kilfoyle
added a commit
that referenced
this pull request
Mar 7, 2024
* Add custom settings page * Fixup * Fix whitespace; replace policy ID with placeholder (cherry picked from commit 4106015) Co-authored-by: David Kilfoyle <[email protected]>
kilfoyle
added a commit
that referenced
this pull request
Mar 7, 2024
* Add custom settings page * Fixup * Fix whitespace; replace policy ID with placeholder (cherry picked from commit 4106015) Co-authored-by: David Kilfoyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #954, this adds examples of agent policy overrides. I've included the warning proposed by Luca here, that it's possible for a custom configuration to break things.
Please see docs preview page
Closes: #954