Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dimensional metrics for elasticsearch.events.processed metric #54

Merged
merged 8 commits into from
Aug 8, 2023
Merged

feat: dimensional metrics for elasticsearch.events.processed metric #54

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d8f20f
feat: use sync counter instead of async
kyungeunni Aug 7, 2023
8dafa07
fix: add correct number
kyungeunni Aug 8, 2023
9d5b534
test: assert event.processed status
kyungeunni Aug 8, 2023
828cd00
chore: make lint happy
kyungeunni Aug 8, 2023
2a0837e
test: expect greater or equal than 2 flush events
kyungeunni Aug 8, 2023
26f6ec7
chore: address review comments
kyungeunni Aug 8, 2023
9230918
fix: revert returning pointer to a metric
kyungeunni Aug 8, 2023
108f8c2
chore: update metric description
kyungeunni Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appender_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ func TestAppenderFlushMetric(t *testing.T) {
if !ignoreCount {
assert.Equal(t, count, int(dp.Count))
} else {
assert.Greater(t, int(dp.Count), count)
assert.GreaterOrEqual(t, int(dp.Count), count)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I debugged it locally with the main branch, and it also quite often emits 2 counts here, it should be ok to expect greater or equal than 2 if I'm not mistaken.

}
assert.Positive(t, dp.Sum)
assert.Equal(t, attrs, dp.Attributes)
Expand Down