Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support otel metrics for existing metrics #51

Merged
merged 11 commits into from
Aug 3, 2023

Conversation

kyungeunni
Copy link
Contributor

closes #37

Support otel metrics for the existing metrics so it can be exported by the client

@kyungeunni kyungeunni marked this pull request as ready for review August 1, 2023 10:00
@kyungeunni kyungeunni requested a review from a team August 1, 2023 10:09
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just minor issues.

metric.go Outdated Show resolved Hide resolved
metric.go Outdated Show resolved Hide resolved
metric.go Outdated Show resolved Hide resolved
metric.go Outdated Show resolved Hide resolved
appender.go Outdated Show resolved Hide resolved
appender.go Outdated Show resolved Hide resolved
appender_test.go Outdated Show resolved Hide resolved
appender_test.go Show resolved Hide resolved
appender_test.go Show resolved Hide resolved
@kyungeunni kyungeunni requested a review from axw August 3, 2023 05:08
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM!

appender_test.go Outdated Show resolved Hide resolved
Co-authored-by: Andrew Wilkins <[email protected]>
@kyungeunni kyungeunni merged commit 2e28098 into elastic:main Aug 3, 2023
2 checks passed
marclop added a commit to marclop/go-docappender that referenced this pull request Aug 16, 2023
Small cleanup following elastic#51.

Signed-off-by: Marc Lopez Rubio <[email protected]>
marclop added a commit that referenced this pull request Aug 16, 2023
Small cleanup following #51.

Signed-off-by: Marc Lopez Rubio <[email protected]>
@kyungeunni kyungeunni deleted the add-otel-metrics branch May 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support OTel metrics
2 participants