Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable race detector for go tests #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: enable race detector for go tests #191

wants to merge 1 commit into from

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Aug 2, 2024 •
edited
Loading

-race was added for the make task in #67 but the ci workflow is still running plain go test:

go-docappender/.github/workflows/ci.yml

Line 40 in 068fe43

run: go test -v ./...

@kruskall kruskall requested a review from a team as a code owner August 2, 2024 22:56
@obltmachine obltmachine added the safe-to-test Automated label for running bench-diff on forked PRs label Aug 2, 2024
@kruskall kruskall enabled auto-merge (squash) August 2, 2024 22:57
@marclop
Copy link
Contributor

marclop commented Aug 12, 2024

Another failed test, seems like it needs fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1pkg 1pkg 1pkg approved these changes

Assignees
No one assigned
Labels
safe-to-test Automated label for running bench-diff on forked PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kruskall @marclop @1pkg @obltmachine