Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUI+] Adjust styles for EuiHorizontalRule snippets #8326

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

acstll
Copy link
Contributor

@acstll acstll commented Feb 14, 2025

Summary

Resolves #8144

  • adjusted alignment for text in main interactive snippet
  • fixed CSS leak affecting margin="none"
  • added background color for items in Margin snippet

QA

  • in the new site, head to /docs/layout/horizontal-rule/ and manually check the snippets
  • make sure code is actually OK

@acstll acstll requested a review from a team as a code owner February 14, 2025 15:11
@acstll acstll self-assigned this Feb 14, 2025
@acstll acstll requested a review from mgadewoll February 17, 2025 14:28
@acstll
Copy link
Contributor Author

acstll commented Feb 17, 2025

@mgadewoll thanks again for the feedback, I think it's much better now 🙂

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @acstll

Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! 🎉 Changes LGTM 👍

@acstll acstll merged commit f2d6b09 into elastic:main Feb 18, 2025
5 checks passed
@acstll acstll deleted the eui-plus-horizontal-rule branch February 18, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EUI+] [EuiHorizontalRule] Fix issues with the component docs
4 participants