[Emotion][perf] Memoize low-impact components (D-F) #7637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ simplify styles array - not sure I love the extra inline styles always being memoized even if they aren't used, but c'est la vie
22 tasks
+ remove unnecessary function for styles w/ no theme token + inline JSX where possible
- disabled opacity is fairly static and can be DRYed out - loading spinner: no styles being applied so this isn't necessary
+ remove passed `layout` arg in favor of static definitions - rewrite vertical vs horizontal gutters utils to be slightly less confusing + replace `calc()` with `mathWithUnits()`
+ prefer inline JSX
cee-chen
force-pushed
the
emotion/memoization-3
branch
from
619e1a8
to
ea2b89d
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
|
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
|
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
|
❌ We're automatically closing this PR due to lack of activity. Please comment if you feel this was done in error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Basically every component that isn't on the medium impact list (#7561) and was easier to do a quick skim through. Some of the commits/components have extra cleanup in terms of
useMemousage, preferring inline JSX, and removing array/obj definitions. As always, I recommend following by commit.QA
General checklist