-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new sections to writing styles with emotion wiki doc #5833
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_5833/ |
Co-authored-by: Caroline Horn <[email protected]>
Preview documentation changes for this PR: https://eui.elastic.co/pr_5833/ |
Co-authored-by: Caroline Horn <[email protected]>
Preview documentation changes for this PR: https://eui.elastic.co/pr_5833/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had two questions about the CSS-aligned-props
section that will help me understand this use case more clearly. These updates capture the new best practices well and actually clued me in to a change I need to make in my own draft PR.
Preview documentation changes for this PR: https://eui.elastic.co/pr_5833/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merging this in so we can keep updating |
Summary
Adds more documentation around our emotion patterns. Sourced from #5685 (comment) and #3912 (comment)
### Checklist