Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new sections to writing styles with emotion wiki doc #5833

Merged
merged 6 commits into from
Apr 26, 2022

Conversation

chandlerprall
Copy link
Contributor

Summary

Adds more documentation around our emotion patterns. Sourced from #5685 (comment) and #3912 (comment)

### Checklist

wiki/writing-styles-with-emotion.md Show resolved Hide resolved
wiki/writing-styles-with-emotion.md Outdated Show resolved Hide resolved
wiki/writing-styles-with-emotion.md Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5833/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5833/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5833/

Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had two questions about the CSS-aligned-props section that will help me understand this use case more clearly. These updates capture the new best practices well and actually clued me in to a change I need to make in my own draft PR.

wiki/writing-styles-with-emotion.md Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5833/

Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cchaos
Copy link
Contributor

cchaos commented Apr 26, 2022

Merging this in so we can keep updating

@cchaos cchaos merged commit b85ffb9 into elastic:main Apr 26, 2022
@chandlerprall chandlerprall deleted the wiki/styling-refs branch April 27, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants