Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align all usages of Jackson to be 2.14.2 #93438

Merged
merged 11 commits into from
Feb 7, 2023

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Feb 2, 2023

upgrading jackson to be 2.14.2 everywhere except for the azure plugin which depends on

jackson-databind  in version 2.13.4.2

and

jackson-core 2.13.4
jackson-dataformat-xml 2.13.4
jackson-datatype-jsr310 2.13.4 
jackson-dataformat-xml 2.13.4

related: #90553
a replace PR for #91725

@pgomulka pgomulka added :Core/Infra/Core Core issues without another label >upgrade v8.7.0 labels Feb 2, 2023
@pgomulka pgomulka self-assigned this Feb 2, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 2, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @pgomulka, I've created a changelog YAML for you.

@pgomulka
Copy link
Contributor Author

pgomulka commented Feb 2, 2023

@elasticmachine run elasticsearch-ci/rest-compatibility

runtimeOnly("com.fasterxml.jackson.core:jackson-databind:2.13.4.2")
runtimeOnly("com.fasterxml.jackson.core:jackson-core:2.13.4")
implementation('com.maxmind.db:maxmind-db:2.1.0')
runtimeOnly("com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a matter of fact com.maxmind.geoip2:geoip2 declares its dependencies as

com.fasterxml.jackson.core » jackson-databind	2.13.4.2
com.fasterxml.jackson.core » jackson-core	2.13.4
com.fasterxml.jackson.core » jackson-annotations	2.13.4

so it could be the same argument as in repository-azure? #91725 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with us locking it onto the same version. We could always unlock it in the future if need be.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was explicitly unlocked in the past. Upgrading Jackson can sometimes be very difficult. This was decoupled from other uses of Jackson so that we can upgrade them independently. Every time we start using versions.jackson again, we recouple them.

@pgomulka
Copy link
Contributor Author

pgomulka commented Feb 2, 2023

@elasticmachine run elasticsearch-ci/bwc

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This looks good to me, not sure about geoip, but I'd imagine it's fine to upgrade.

@pgomulka pgomulka merged commit e6bbfa2 into elastic:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >upgrade v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants