Skip to content

[8.19] Remove dead @TestIssueLogging anns from repo-s3 (#129906) #129921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.19
Choose a base branch
from
+0 −19
Open

[8.19] Remove dead @TestIssueLogging anns from repo-s3 (#129906) #129921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions modules/repository-s3/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,6 @@ esplugin.bundleSpec.from('config/repository-s3') {
into 'config'
}

tasks.named("internalClusterTest").configure {
// TODO: remove once https://github.com/elastic/elasticsearch/issues/101608 is fixed
systemProperty 'es.insecure_network_trace_enabled', 'true'
}

tasks.named("thirdPartyAudit").configure {
ignoreMissingClasses(
// missing/unused classes
Expand Down
14 changes: 0 additions & 14 deletions ...nternalClusterTest/java/org/elasticsearch/repositories/s3/S3BlobStoreRepositoryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
import org.elasticsearch.test.BackgroundIndexer;
import org.elasticsearch.test.ESIntegTestCase;
import org.elasticsearch.test.MockLog;
import org.elasticsearch.test.junit.annotations.TestIssueLogging;
import org.elasticsearch.threadpool.ThreadPool;
import org.elasticsearch.xcontent.NamedXContentRegistry;
import org.elasticsearch.xcontent.XContentFactory;
Expand Down Expand Up @@ -178,15 +177,6 @@ protected Settings nodeSettings(int nodeOrdinal, Settings otherSettings) {
return builder.build();
}

@Override
@TestIssueLogging(
issueUrl = "https://github.com/elastic/elasticsearch/issues/88841",
value = "com.amazonaws.request:DEBUG,com.amazonaws.http.AmazonHttpClient:TRACE"
)
public void testRequestStats() throws Exception {
super.testRequestStats();
}

public void testAbortRequestStats() throws Exception {
final String repository = createRepository(randomRepositoryName(), false);

Expand Down Expand Up @@ -228,10 +218,6 @@ public void testAbortRequestStats() throws Exception {
assertEquals(assertionErrorMsg, mockCalls, sdkRequestCounts);
}

@TestIssueLogging(
issueUrl = "https://github.com/elastic/elasticsearch/issues/101608",
value = "com.amazonaws.request:DEBUG,com.amazonaws.http.AmazonHttpClient:TRACE"
)
public void testMetrics() throws Exception {
// Create the repository and perform some activities
final String repository = createRepository(randomRepositoryName(), false);
Expand Down