[8.19] Fix MixedClusterEsqlSpecIT 8.11 BWC #129841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afoucret
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
afoucret
changed the title
ivancea
approved these changes
Jun 25, 2025
| @@ -151,6 +151,13 @@ protected boolean supportsAsync() { | |||
| return clusterHasFeature(ASYNC_QUERY_FEATURE_ID); // the Async API was introduced in 8.13.0 | |||
| } | |||
|
|
|||
| @After | |||
| public void wipeInferenceEndpoints() throws IOException { | |||
| if (supportsAsync()) { | |||
There was a problem hiding this comment.
I suppose those inference endpoints were added between 8.11 and 8.13?
| @@ -151,6 +151,13 @@ protected boolean supportsAsync() { | |||
| return clusterHasFeature(ASYNC_QUERY_FEATURE_ID); // the Async API was introduced in 8.13.0 | |||
| } | |||
|
|
|||
| @After | |||
There was a problem hiding this comment.
Some reason to have it in the @After now? As it was working before in the @AfterClass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #129674
Fix for #129596