Skip to content

Enable time-series block hash #127488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025
Merged

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Apr 28, 2025

This change enables time-series block hashing for time-series aggregation when the input is sorted. The hashing time for this query against TSDB is reduced from 3.7 seconds to 1.2 seconds:

TS tsdb 
| STATS sum(rate(kubernetes.container.memory.pagefaults)) BY bucket(@timestamp, 5minute)

@dnhatn dnhatn force-pushed the enable-time-series-block branch 2 times, most recently from 3ea43de to 439ee19 Compare April 29, 2025 01:41
@dnhatn dnhatn force-pushed the enable-time-series-block branch from 439ee19 to af674a3 Compare April 29, 2025 05:40
@dnhatn dnhatn added >non-issue :StorageEngine/TSDB You know, for Metrics labels Apr 29, 2025
@dnhatn dnhatn requested a review from kkrik-es April 29, 2025 05:55
@dnhatn dnhatn marked this pull request as ready for review April 29, 2025 05:55
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@dnhatn dnhatn mentioned this pull request Apr 29, 2025
13 tasks
@@ -299,6 +303,24 @@ public final Operator.OperatorFactory ordinalGroupingOperatorFactory(
);
}

@Override
public Operator.OperatorFactory timeSeriesAggregatorOperatorFactor(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit: s/Factor/Factory/

Copy link
Contributor

@kkrik-es kkrik-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great wins, keep them coming.

@dnhatn
Copy link
Member Author

dnhatn commented Apr 29, 2025

Thanks Kostas!

@dnhatn dnhatn merged commit 63b55e4 into elastic:main Apr 29, 2025
16 of 17 checks passed
@dnhatn dnhatn deleted the enable-time-series-block branch April 29, 2025 17:30
dnhatn added a commit that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants