add stable ThreadPool constructor to LogstashInternalBridge #105163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
yaauie
added
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
removed
the
needs:triage
yaauie
force-pushed
the
logstash-bridge-threadpool-main
branch
from
a4b4113 to
083638b
Compare
|
Hi @yaauie, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
joegallo
approved these changes
Feb 7, 2024
joegallo
pushed a commit
that referenced
this pull request
Feb 7, 2024
yaauie
added a commit
to yaauie/logstash-filter-elastic_integration
that referenced
this pull request
Feb 9, 2024
Introduced on Elasticsearch `main` in elastic/elasticsearch#105163 and backported to `8.12` in elastic/elasticsearch#105163. Migrating to this stable API allows our build to work across the 8.12->8.13 boundary in which we observed a change to the ThreadPool's constructor. Resolves: elastic#120
yaauie
added a commit
to elastic/logstash-filter-elastic_integration
that referenced
this pull request
Feb 12, 2024
Introduced on Elasticsearch `main` in elastic/elasticsearch#105163 and backported to `8.12` in elastic/elasticsearch#105163. Migrating to this stable API allows our build to work across the 8.12->8.13 boundary in which we observed a change to the ThreadPool's constructor. Resolves: #120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the discussion started in #104959, which adds a
ThreadPoolfactory method to theLogstashInternalBridgein order to provide Logstash's Elastic Integration Filter with an API-stable way to create theThreadPoolit needs, along with tests to ensure that internal refactoring does not break this external usage.This PR has a companion in the 8.12 series (#105165) that must also be merged, so that the Elastic Integration Filter can begin instantiating
ThreadPoolinstance against an API that is stable across the8.12->mainjump.