Remove Experimental Labels for SparseVectorQuery Token Pruning for GA #4454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kderusso
reviewed
Jun 4, 2025
| "stack": { | ||
| "since": "8.15.0", | ||
| "stability": "experimental" | ||
| "since": "8.15.0" |
There was a problem hiding this comment.
Did you automatically regenerate these files, or hand edit them? I think we still need the stack version information and I'm surprised if it got wiped out automatically.
There was a problem hiding this comment.
I followed the CONTRIBUTING instructions and ran make contrib -- should the since label be updated to 8.19?
There was a problem hiding this comment.
I don't think so, because it's still available in previous APIs? Maybe we can get help from the clients team to confirm this is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small PR to remove the
stability=experimentaltags for the pruning configuration items for thesparse_vectorquery type.