Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding project created for content about Building a recipe search with Elasticsearch #350

Conversation

andreluiz1987
Copy link
Contributor

This PR contains scripts used for the article Building a recipe search with Elasticsearch

@carlyrichmond carlyrichmond self-requested a review November 4, 2024 14:44
Copy link
Contributor

@carlyrichmond carlyrichmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be converted to a Python notebook.

Can you check the pre-commit stage failure as well? Chatting with @JessicaGarson we want to confirm if you have setup the pre-commit stage correctly.

python -m venv .venv .venv/bin/pip install -qqq -r requirements-dev.txt .venv/bin/pre-commit install

Let us know if anything doesn't make sense!

@andreluiz1987
Copy link
Contributor Author

I believe this should be converted to a Python notebook.

Can you check the pre-commit stage failure as well? Chatting with @JessicaGarson we want to confirm if you have setup the pre-commit stage correctly.

python -m venv .venv .venv/bin/pip install -qqq -r requirements-dev.txt .venv/bin/pre-commit install

Let us know if anything doesn't make sense!

Hi Carly, I will make the corrections.

@carlyrichmond carlyrichmond merged commit 4f92c8f into elastic:main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants