-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated cohere notebook for video #317
Conversation
Found 1 changed notebook. Review the changes at https://gitnotebooks.com/elastic/elasticsearch-labs/pull/317 |
nitpick: rename the notebook to You also need to exclude this notebook from our tests https://github.com/elastic/elasticsearch-labs/blob/main/bin/find-notebooks-to-test.sh#L3 Will review once CI passes! You might have issue with formatting on CI so follow contributing guide |
"source": [ | ||
"Now you can instantiate the Python Elasticsearch client.\n", | ||
"\n", | ||
"First provide your password and Cloud ID.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example uses an API key, not a password.
When I ran the ingest step I got an index error. The rest of the notebook worked.
|
Looks good! Something like
|
@jeffvestal , were you using a cohere production API key or a trial key? |
I think it was a prod key, but let me run through it again with a new prod key to double-check. |
Thanks! I am just trying to think of reasons that some of the documents would fail to ingest. It worked every time I tried it. |
Alright, @maxhniebergall it must have been me using the wrong key 🫠 |
Thanks Jeff! |
building on https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank