Pin eland to 8.12.1 to avoid build failures #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 4 changed notebooks. Review the changes at https://gitnotebooks.com/elastic/elasticsearch-labs/pull/218 |
miguelgrinberg
force-pushed
the
pin-eland-8.12
branch
from
1492cf8
to
5547d73
Compare
joemcelroy
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are putting a temporary pin on eland==8.12, since eland 8.13 does not work with stacks older than 8.13.
While testing this change I discovered a very minor difference in the results of a kNN request with k=10 between 8.14-SNAPSHOT and the older stacks. I was able to avoid this difference by lowering to k=5.