Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esql-getting-started.ipynb #215

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Update esql-getting-started.ipynb #215

merged 2 commits into from
Mar 27, 2024

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Mar 27, 2024

Closes #207

Copy link

gitnotebooks bot commented Mar 27, 2024

Found 1 changed notebook. Review the changes at https://gitnotebooks.com/elastic/elasticsearch-labs/pull/215

@@ -1156,7 +1156,7 @@
"client.enrich.put_policy(name=\"clientip_policy\", body=policy)\n",
"\n",
"# Execute the enrich policy without waiting for completion\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the comment be updated as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It certainly should, thanks

Copy link
Collaborator

@miguelgrinberg miguelgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leemthompo leemthompo merged commit 6db1388 into main Mar 27, 2024
5 checks passed
@leemthompo leemthompo deleted the leemthompo-patch-1 branch March 27, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enrich error for "Getting started with ES|QL" notebook
2 participants