-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add esql getting started notebook #201
Conversation
Found 1 changed notebook. Review the changes at https://gitnotebooks.com/elastic/elasticsearch-labs/pull/201 |
@miguelgrinberg CI is failing on the enrich policy in this notebook:
Any idea what's at play here? Didn't hit any issues when running the notebook on colab against an 8.13 cluster. If testing logic is trying to interact with the enrich index directly using a static index name like |
@leemthompo are there any differences between cloud and docker image with regards to this? The tests run against a self-hosted minimal container, so the behavior might be different than running against cloud. Another issue you are going to hit is that the notebook is also going to run against 8.11 and 8.12. Sounds like I'll need to figure out a mechanism to specify which versions a notebook needs to run on. |
@miguelgrinberg I've tested the notebook locally against a single-node Docker ES instance, and indeed the
Yes, we hit similar issues with Aurelien's LTR notebook failing pre-8.12 tests. |
The easy option is to add this notebook to the exempt list in this file. The hard option would be to figure out this failure and adapt the notebook to work under Docker as well. And I need to expand the file I linked above to be version aware and provide different lists of notebooks to skip for each given stack release, which I'm planning to anyway. |
I'm not sure if multi-node Docker clusters solves the issue, but unfortunately I ran out of time to confirm this today. |
I don't think we can stand up a multi-node Docker instance within the resource constrained GitHub Actions environment. I think the best course of action for now is to skip this notebook when testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome notebook! It has a great flow and is easy to follow. I tested it end-to-end on a 8.14 cluster (es-py 8.12.0) and it worked flawlessly.
Ports getting started to Python.
TODO