Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics, file logging and ILogger integration #34

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

stevejgordon
Copy link
Contributor

Initial design for diagnostics with a file logger implementation. Includes support for registering services into DI so we can also access an ILogger that can be used to log to the console.

@stevejgordon stevejgordon marked this pull request as ready for review February 13, 2024 11:33
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed together offline, LGTM

@stevejgordon stevejgordon merged commit 592036b into main Feb 13, 2024
3 of 4 checks passed
@stevejgordon stevejgordon deleted the diagnostics branch February 13, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants