Fix double question mark in http.target (#157)

As titled
elastic · Sep 10, 2024 · 2d47f7e · 2d47f7e
1 parent 410d127
commit 2d47f7e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Elastic.OpenTelemetry/Processors/ElasticCompatibilityProcessor.cs b/src/Elastic.OpenTelemetry/Processors/ElasticCompatibilityProcessor.cs
@@ -88,7 +88,7 @@ public override void OnEnd(Activity activity)
 				var target = urlPath;
 
 				if (urlQuery is not null)
-					target += $"?{urlQuery}";
+					target += urlQuery;
 
 				SetStringAttribute(HttpTarget, target);
 			}

diff --git a/tests/Elastic.OpenTelemetry.Tests/Processors/ElasticCompatibilityProcessorTests.cs b/tests/Elastic.OpenTelemetry.Tests/Processors/ElasticCompatibilityProcessorTests.cs
@@ -74,7 +74,7 @@ public void AddsExpectedHttpAttributes_WhenUrlQuery_IsPresent()
 	{
 		const string scheme = "https";
 		const string path = "/my/path";
-		const string query = "q=OpenTelemetry";
+		const string query = "?q=OpenTelemetry";
 
 		var activity = _activitySource.CreateActivity("test", ActivityKind.Server)!;
 
@@ -87,7 +87,7 @@ public void AddsExpectedHttpAttributes_WhenUrlQuery_IsPresent()
 
 		// We can test with Tags (rather than TagObjects) here as we know these are string values
 		activity.Tags.Single(t => t.Key == TraceSemanticConventions.HttpScheme).Value.Should().Be(scheme);
-		activity.Tags.Single(t => t.Key == TraceSemanticConventions.HttpTarget).Value.Should().Be($"{path}?{query}");
+		activity.Tags.Single(t => t.Key == TraceSemanticConventions.HttpTarget).Value.Should().Be($"{path}{query}");
 	}
 
 	public void Dispose()