-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otel/kube-stack] Update EDOT SDK k8s auto-instrumentation images to their latest versions #7327
[otel/kube-stack] Update EDOT SDK k8s auto-instrumentation images to their latest versions #7327
Conversation
…their latest versions This also updates the vanilla OTel Go image version to its latest.
This pull request does not have a backport label. Could you fix it @trentm? 🙏
|
I'd appreciate guidance on this. I don't know what backport targets would be appropriate for this PR. |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
hey @trentm 👋 so |
Sorry I would love to be more helpful here but I'm not familiar with the expectation of auto instrumentation SDK version bump risk and reward balance in backported versions. |
yeah, these can be backported to any/every version and will work fine (and be better for the customer) |
I'm reluctant to do this right before the final RC for 9.0.0 and 8.18.0 unless someone exhaustively tests these first. We don't have enough automated testing for this configuration to be confident we're not breaking something. See #7381 for a very recent example. |
To be clear what this change is, it is changing the default agent docker images that are downloaded into the kubernetes cluster that the customer is running, which can then be applied for auto-instrumentation of customer applications. The customer is able to override these docker images very easily. Sticking with the existing values means that customers onboarding will install old versions of the agents, applying the change means the customers install the latest released (and definitely tested) versions of the agents When we defined these values, we considered using All of which is to say, this not a risk on the Elastic infrastructure side, it only affects agent versions downloaded into customer clusters, and the more recent version the better where this is concerned |
@jackshirazi I understand what this change accomplishes. I'm saying I'm not confident this won't break something for customers. If @elastic/ingest-otel-data, who are effectively the owners of this config, are confident the change is safe, I don't mind merging it. |
@elastic/ingest-otel-data can we merge this? I'm not clear on what versions this should be backported to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with merging this, after syncing with the other team members, as soon as #7327 (comment) is resolved. I think the risk is relatively low, considering this PR only affects auto-instrumentation and not the collector configuration or elastic-agent image used.
We should backport to at least 8.19 and 9.1 at the very least, but also 9.0.1 and 8.18.1.
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @trentm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
…their latest versions (#7327) * [otel/kube-stack] Update EDOT SDK k8s auto-instrumentation images to their latest versions This also updates the vanilla OTel Go image version to its latest. * Apply suggestions from code review * update to docker.elastic.co/observability/elastic-otel-node:1.0.0 * bump docker image version for elastic-otel-python * Update deploy/helm/edot-collector/kube-stack/values.yaml * Update deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml --------- Co-authored-by: Riccardo Magliocchetti <[email protected]> Co-authored-by: Davide Girardi <[email protected]> (cherry picked from commit 6e1427c)
…their latest versions (#7327) * [otel/kube-stack] Update EDOT SDK k8s auto-instrumentation images to their latest versions This also updates the vanilla OTel Go image version to its latest. * Apply suggestions from code review * update to docker.elastic.co/observability/elastic-otel-node:1.0.0 * bump docker image version for elastic-otel-python * Update deploy/helm/edot-collector/kube-stack/values.yaml * Update deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml --------- Co-authored-by: Riccardo Magliocchetti <[email protected]> Co-authored-by: Davide Girardi <[email protected]> (cherry picked from commit 6e1427c)
…their latest versions (#7327) * [otel/kube-stack] Update EDOT SDK k8s auto-instrumentation images to their latest versions This also updates the vanilla OTel Go image version to its latest. * Apply suggestions from code review * update to docker.elastic.co/observability/elastic-otel-node:1.0.0 * bump docker image version for elastic-otel-python * Update deploy/helm/edot-collector/kube-stack/values.yaml * Update deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml --------- Co-authored-by: Riccardo Magliocchetti <[email protected]> Co-authored-by: Davide Girardi <[email protected]> (cherry picked from commit 6e1427c)
…their latest versions (#7327) * [otel/kube-stack] Update EDOT SDK k8s auto-instrumentation images to their latest versions This also updates the vanilla OTel Go image version to its latest. * Apply suggestions from code review * update to docker.elastic.co/observability/elastic-otel-node:1.0.0 * bump docker image version for elastic-otel-python * Update deploy/helm/edot-collector/kube-stack/values.yaml * Update deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml --------- Co-authored-by: Riccardo Magliocchetti <[email protected]> Co-authored-by: Davide Girardi <[email protected]> (cherry picked from commit 6e1427c)
…their latest versions (#7327) (#7708) * [otel/kube-stack] Update EDOT SDK k8s auto-instrumentation images to their latest versions This also updates the vanilla OTel Go image version to its latest. * Apply suggestions from code review * update to docker.elastic.co/observability/elastic-otel-node:1.0.0 * bump docker image version for elastic-otel-python * Update deploy/helm/edot-collector/kube-stack/values.yaml * Update deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml --------- Co-authored-by: Riccardo Magliocchetti <[email protected]> Co-authored-by: Davide Girardi <[email protected]> (cherry picked from commit 6e1427c) Co-authored-by: Trent Mick <[email protected]>
…their latest versions (#7327) (#7709) * [otel/kube-stack] Update EDOT SDK k8s auto-instrumentation images to their latest versions This also updates the vanilla OTel Go image version to its latest. * Apply suggestions from code review * update to docker.elastic.co/observability/elastic-otel-node:1.0.0 * bump docker image version for elastic-otel-python * Update deploy/helm/edot-collector/kube-stack/values.yaml * Update deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml --------- Co-authored-by: Riccardo Magliocchetti <[email protected]> Co-authored-by: Davide Girardi <[email protected]> (cherry picked from commit 6e1427c) Co-authored-by: Trent Mick <[email protected]>
…their latest versions (#7327) (#7710) * [otel/kube-stack] Update EDOT SDK k8s auto-instrumentation images to their latest versions This also updates the vanilla OTel Go image version to its latest. * Apply suggestions from code review * update to docker.elastic.co/observability/elastic-otel-node:1.0.0 * bump docker image version for elastic-otel-python * Update deploy/helm/edot-collector/kube-stack/values.yaml * Update deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml --------- Co-authored-by: Riccardo Magliocchetti <[email protected]> Co-authored-by: Davide Girardi <[email protected]> (cherry picked from commit 6e1427c) Co-authored-by: Trent Mick <[email protected]>
This also updates the vanilla OTel Go image version to its latest.
The versions of the EDOT language SDK images being used with the OTel Operator were quite old.
This manually updates them to the current latest.
/cc @jackshirazi, @xrmx, @dmathieu (as my best guess for the authority on the OTel Operator auto-instrumentation image for each of the languages I've updated here)
Is there a good place to discuss how/when/who should be regularly updating these versions?
Or perhaps use the
:latest
Docker tag, though that, of course, changes over time.