Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #6410) Add logging to EventLog for error, install, uninstall #6453

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 31, 2024

What does this PR do?

On Windows, if the install, uninstall, or enroll commands fail, they will now attempt to add the error to the Windows Application Event Log. This is the same behavior that the run command has.

Why is it important?

If any of these commands are done with automation it can be difficult to capture the errors that appear on standard error. This gives us a chance of capturing the error and reviewing later.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

  1. Build with this PR
  2. Run Install
  3. Try to uninstall with bad arguments or a file open in the install directory
  4. Error should be visible in the Event Viewer

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #6410 done by [Mergify](https://mergify.com).

Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 565d139)
@mergify mergify bot added the backport label Dec 31, 2024
@mergify mergify bot requested a review from a team as a code owner December 31, 2024 07:31
@mergify mergify bot requested review from kaanyalti and andrzej-stencel and removed request for a team December 31, 2024 07:31
@jlind23 jlind23 enabled auto-merge (squash) December 31, 2024 07:33
@jlind23 jlind23 merged commit 449a7e8 into 8.x Dec 31, 2024
13 of 14 checks passed
@jlind23 jlind23 deleted the mergify/bp/8.x/pr-6410 branch December 31, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants