Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging to EventLog for error, install, uninstall #6410

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Add logging to EventLog for error, install, uninstall #6410

merged 2 commits into from
Dec 31, 2024
+35 −0

Conversation

leehinman
Copy link
Contributor

What does this PR do?

On Windows, if the install, uninstall, or enroll commands fail, they will now attempt to add the error to the Windows Application Event Log. This is the same behavior that the run command has.

Why is it important?

If any of these commands are done with automation it can be difficult to capture the errors that appear on standard error. This gives us a chance of capturing the error and reviewing later.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

  1. Build with this PR
  2. Run Install
  3. Try to uninstall with bad arguments or a file open in the install directory
  4. Error should be visible in the Event Viewer

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@leehinman leehinman requested a review from a team as a code owner December 19, 2024 17:08
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024

This pull request does not have a backport label. Could you fix it @leehinman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 19, 2024
@leehinman leehinman force-pushed the 6338_add_more_event_log branch from 11341c1 to 4a00f25 Compare December 19, 2024 17:09
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@jlind23 jlind23 merged commit 565d139 into elastic:main Dec 31, 2024
13 checks passed
mergify bot pushed a commit that referenced this pull request Dec 31, 2024
@leehinman @mergify
Add logging to EventLog for error, install, uninstall (#6410)
1cda86b 
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 565d139)
@mergify mergify bot mentioned this pull request Dec 31, 2024
Merged
7 tasks
jlind23 pushed a commit that referenced this pull request Dec 31, 2024
@mergify @leehinman
Add logging to EventLog for error, install, uninstall (#6410) (#6453)
449a7e8 
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 565d139)

Co-authored-by: Lee E Hinman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@leehinman leehinman

Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add logging to Event Log for install, uninstall, and enroll subcommands
3 participants
@leehinman @andrzej-stencel @jlind23