Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip failing model config tests #635

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Skip failing model config tests #635

merged 1 commit into from
Nov 21, 2023

Conversation

davidkyle
Copy link
Member

Due to #633

@davidkyle davidkyle added ci issues related to continuous integration topic:NLP Issue or PR about NLP model support and eland_import_hub_model labels Nov 16, 2023
pquentin
pquentin approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm confused - Is #634 supposed to help with that or is it unrelated?

@davidkyle
Copy link
Member Author

Is #634 supposed to help with that or is it unrelated?

No the test failures will need another fix. Updating the machine type in #634 is general maintenance

@davidkyle davidkyle merged commit b689759 into elastic:main Nov 21, 2023
4 checks passed
@davidkyle davidkyle deleted the mute-model-tests branch November 21, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
ci issues related to continuous integration topic:NLP Issue or PR about NLP model support and eland_import_hub_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidkyle @pquentin