Fix TCP close events for "idle" connections. Fixes #217 #220
+81
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the condition to supress a close, before it would supress any sockets
that had no traffic.
Now we keep state of sockets we sent an attempt/accept and supress the ones we
didn't track _AND_ had no traffic. The map is limited, once we have 128k active
sockets we can't track them, so fallback to looking at bytes_received and
bytes_sent.
We don't really look at tgid, but we will on upcoming probes.
Maps are not small, most of the allocation size goes to the hash bucket. The
empty map wires 2MB of memory.
6306: hash name sk_to_tgid flags 0x1
key 8B value 4B max_entries 131072 memlock 2098760B
btf_id 5117
pids EventsTrace(2868637)
stanek-michal
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the condition to supress a close, before it would supress any sockets that had no traffic.
Now we keep state of sockets we sent an attempt/accept and supress the ones we didn't track AND had no traffic. The map is limited, once we have 128k active sockets we can't track them, so fallback to looking at bytes_received and bytes_sent.
We don't really look at tgid, but we will on upcoming probes. Maps are not small, most of the allocation size goes to the hash bucket. The empty map wires 2MB of memory.
6306: hash name sk_to_tgid flags 0x1
key 8B value 4B max_entries 131072 memlock 2098760B
btf_id 5117
pids EventsTrace(2868637)