-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(all): only build docs if there's a doc change #3067
base: master
Are you sure you want to change the base?
Conversation
extend the check to all remaining repositories
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
"kibana") | ||
git fetch origin "$GITHUB_PR_TARGET_BRANCH" | ||
docs_diff=$(git diff --stat "origin/$GITHUB_PR_TARGET_BRANCH"...HEAD -- ./docs ":(glob)x-pack/**/*.asciidoc" ":(glob)src/**/*.asciidoc" ":(glob)examples/**/*.asciidoc") | ||
;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lcawl I might need your expertise on the link checking service to make sure we include the right file(s) here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct for every other repo. The Kibana repo, however, has a unique job that is defined outside of conf.yaml
—link checking doc links from within the product.
Here's the function:
Line 345 in 53a7366
sub check_kibana_links { |
There's a chance that it's as easy as adding these two files:
Line 393 in 53a7366
my $src_path = 'src/ui/public/documentation_links/documentation_links'; |
Line 394 in 53a7366
my $legacy_path = 'src/legacy/ui/public/documentation_links/documentation_links'; |
This is incredible |
extend the check to all remaining repositories