Cancel existing builds on running PRs #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkammah
requested review from
colleenmcginnis,
kilfoyle,
leemthompo and
a team
as code owners
|
run docs-build |
gtback
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #2835, the docs-pr job always trigger the master branch of the Buildkite job. A PR in repo1 and another PR in repo 2 will both call the head code of the master branch of the elastic/docs and the job itself is configured to fetch the PR content. As a result, I had to disable cancelling intermediate builds since that would mean only one build at a time can run. The downside is that 2 commits in a row on the same PR will trigger a build twice for the same PR.
To tackle this, we introduce this PR that filters the existing running builds (by inspecting the build metadata to check if it came from a specific PR) and cancel the running builds.
Note: while the Buildkite API doc states that we can filter builds by meta_data, it does not work :( as a result, we have to run some jq shenanigans.