Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces docs for serverless #55

Merged
merged 23 commits into from
Oct 21, 2024

Conversation

florent-leborgne
Copy link
Contributor

@florent-leborgne florent-leborgne commented Sep 16, 2024

This PR adds a page about Spaces to the serverless docs as spaces will be included for GA.

This basically adapts the stateful version of the Kibana guide's Spaces page into the serverless docs.

Might need to confirm that the following unconfirmed differences with stateful are intended:

  • Didn't find any option to copy an object to a different space (removed from this doc in the meantime), leaving the import/export of saved object the only way available to do so. Confirmed copy is possible and added.
  • Didn't find option to set role privileges on the space, while custom roles should also become available in serverless (so it's not documented here for now) Link to custom roles added (behind same feature flag as the custom roles docs)
  • Required privileges. With the new serverless user model, the role needed is different. I'll need to confirm whether there are specific roles per solution that allow to do this or if it's just the generic admin role. Also to check if we want to add the specific privilege to use for when custom roles become available.

Note - The following differences were confirmed:

  • Feature visibility isn't available on serverless
  • New solution view setting isn't available either (which is logical :D)

Closes: https://github.com/elastic/platform-docs-team/issues/471

@florent-leborgne florent-leborgne added the documentation Improvements or additions to documentation label Sep 16, 2024
@florent-leborgne florent-leborgne self-assigned this Sep 16, 2024
@florent-leborgne
Copy link
Contributor Author

cc @lcawl about the link to the Spaces API for serverless, whenever it gets published we can update the link to it in this PR if it's not yet merged.

@elasticdocs
Copy link
Collaborator

elasticdocs commented Sep 16, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

joepeeples added a commit to elastic/security-docs that referenced this pull request Sep 25, 2024
This link will be broken until elastic/docs-content#55 is merged
@florent-leborgne florent-leborgne marked this pull request as ready for review September 26, 2024 08:36
@florent-leborgne florent-leborgne requested a review from a team as a code owner September 26, 2024 08:36
@florent-leborgne
Copy link
Contributor Author

florent-leborgne commented Sep 30, 2024

@kevinsweet @bitzandeb @legrego Please take a look and let me know what you think. I tried to stick to the corresponding version of the page for stateful, with the differences listed in the PR description.

You can find preview the new page here if you prefer it to the file diff https://elastic-dot-co-docs-production-adyr7eazr-elastic-dev.vercel.app/current/serverless/spaces

serverless/pages/spaces.mdx Outdated Show resolved Hide resolved
serverless/pages/spaces.mdx Outdated Show resolved Hide resolved
serverless/pages/spaces.mdx Outdated Show resolved Hide resolved
serverless/pages/spaces.mdx Outdated Show resolved Hide resolved
@florent-leborgne
Copy link
Contributor Author

@lcawl pinging you as this now also touches Custom roles, since you worked on it, if you want to take a look

wajihaparvez
wajihaparvez previously approved these changes Oct 11, 2024
serverless/pages/saved-objects.mdx Show resolved Hide resolved
serverless/pages/saved-objects.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐴

@florent-leborgne florent-leborgne merged commit 765bd74 into elastic:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:doc-build documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants