Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add Ingest tools overview and Upload data files #526

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

wajihaparvez
Copy link
Contributor

@wajihaparvez wajihaparvez commented Feb 20, 2025

Closes: #327 and #444
Previews: Ingest tools overview and Upload data files

Summary

  • As discussed, combined content from linked resources to add a table for the tools overview. A lot of pages have moved around so I'd really appreciate a quick double-check of the links to make sure they're pointing to the right location 🙏
  • Added content to the Upload data files page and changed its location (see questions below)

Questions

  1. Since we decided that a table would work best for the overview, I'm not sure how to incorporate https://www.elastic.co/guide/en/cloud/current/ec-cloud-ingest-data.html on this page. I don't think all of its content fits here based on the new IA. Maybe it could go in the reference section? I'm open to any ideas!!
  2. The Upload data files page was originally nested under the Ingest tools overview, but I think it's better suited as a sibling in the overall Manage data/Ingest section. What do you think?

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦘
Nice work! I checked all of the links and they work swimmingly.

For your questions:

Since we decided that a table would work best for the overview, I'm not sure how to incorporate https://www.elastic.co/guide/en/cloud/current/ec-cloud-ingest-data.html on this page. I don't think all of its content fits here based on the new IA. Maybe it could go in the reference section? I'm open to any ideas!!

That "Adding data to Elasticsearch" page is now extinct, but I think it would be helpful to say something in the first paragraph of your tools page, something like, "Refer to our [[Ingest]] overview for some guidelines to help you select the optimal tool for your use case."

The Upload data files page was originally nested under the Ingest tools overview, but I think it's better suited as a sibling in the overall Manage data/Ingest section. What do you think?

I like the new location!

One suggestion: The order of the tools isn't really obvious to me. I'm not sure if they should be alphabetical or just left as is, but if indeed the order is sort of random, perhaps bump "Integrations" further up in the list, since those are really the preferred mechanism for ingesting data. Just a thought.

@wajihaparvez
Copy link
Contributor Author

Thanks for reviewing and answering my questions, @kilfoyle! I've incorporated your suggestions. The order of the tools is indeed random, so I can definitely move things around if they make sense in a different order. Let me know 🙂

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦕
Looks good! Thanks for moving "integrations" to the top.

@wajihaparvez wajihaparvez enabled auto-merge (squash) February 20, 2025 15:59
@wajihaparvez wajihaparvez merged commit 7254fdc into elastic:main Feb 20, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants