-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add Index basics page #464
Conversation
…aparvez/docs-content into 369/index-basics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach makes sense to me! I left a couple comments below that are more technical than editorial.
Investigate your indices and perform operations from the **Indices** view. | ||
|
||
:::{image} /images/serverless-index-management-indices.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images in this PR aren't showing up for me in the preview... I'm not sure, but this might help.
:::{image} /images/serverless-index-management-indices.png | |
:::{image} ../../images/serverless-index-management-indices.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the issue was but when I was adding the ../../
on Friday, the deployment was failing. I can see the images in the preview now, could you confirm if that's true for you as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I had to hard refresh to get the page built with the latest docs-builder update (including the redesign). After that I can see the images. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Closes #369
Preview here
Summary
What I changed:
I'll delete the code comments after this is reviewed. @colleenmcginnis @kilfoyle let me know what you think of these decisions. I'm open to all insight/suggestions 😄