Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates attack-discovery.md #453

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updates attack-discovery.md #453

wants to merge 1 commit into from

Conversation

jmikell821
Copy link
Contributor

For migration cleanup. Check on syntax for embedded videos.

::::{admonition}
<script type="text/javascript" async src="https://play.vidyard.com/embed/v4.js"></script>
<img
  style="width: 100%; margin: auto; display: block;"
  class="vidyard-player-embed"
  src="https://play.vidyard.com/eT92arEbpRddmSM4JeyzdX.jpg"
  data-uuid="eT92arEbpRddmSM4JeyzdX"
  data-v="4"
  data-type="inline"
/>
</br>
::::

For a demo, refer to the following video.

<!-- ::::{admonition}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current syntax guide doesn't contain guidance for videos. Florent seemed to have figured out a workaround (see this Slack thread) that we might be able to use if needed.


* Click an entity’s name to open the user or host details flyout and view more details that may be relevant to your investigation.
* Hover over an entity’s name to either add the entity to Timeline (![Add to timeline icon](../../../images/security-icon-add-to-timeline.png "")) or copy its field name and value to the clipboard (![Copy to clipboard icon](../../../images/security-icon-copy.png "")).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resizes the icons and makes them smaller

Suggested change
* Hover over an entity’s name to either add the entity to Timeline (![Add to timeline icon](../../../images/security-icon-add-to-timeline.png "")) or copy its field name and value to the clipboard (![Copy to clipboard icon](../../../images/security-icon-copy.png "")).
* Hover over an entity’s name to either add the entity to Timeline (![Add to timeline icon](../../../images/security-icon-add-to-timeline.png "title =20x20")) or copy its field name and value to the clipboard (![Copy to clipboard icon](../../../images/security-icon-copy.png "title =20x20")).

Comment on lines +49 to +51
* [What information each discovery includes](#attack-discovery-what-info)
* [How you can interact with discoveries to enhance {{elastic-sec}} workflows](#attack-discovery-workflows)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These anchor links aren't working properly in the preview, but since the syntax looks correct and the build is passing, it probably shouldn't be a blocker for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants